Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix/photouploadcrash] Fix automatic photo upload crash on iOS 15 #1017

Merged
merged 5 commits into from
Sep 16, 2021

Conversation

felix-schwarz
Copy link
Contributor

Description

On iOS 15, automatic photo upload seems to consume more resources than are available, leading to a crash. This pull requests reduces the number of concurrent photo upload operations from available cores to 1.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@michaelstingl michaelstingl modified the milestones: 11.6.1-Fix, 11.7.1-Fix Aug 9, 2021
@felix-schwarz felix-schwarz changed the base branch from master to milestone/11.7.1 August 16, 2021 08:45
@jesmrec
Copy link
Contributor

jesmrec commented Sep 16, 2021

This one is related with performance and not easy to reproduce. I'd move it forward and wait for feedback in case the problem persist. What do you think?

@hosy
Copy link
Collaborator

hosy commented Sep 16, 2021

@jesmrec yes I think this is not easy to reproduce and you can finish without further testing. Thanks!

@hosy hosy merged commit fd61c6e into milestone/11.7.1 Sep 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/photouploadcrash branch September 16, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants