[feature/share-extension-account-items] Expanded Single Account / Additional Items #1296

hosy · 2023-11-16T17:31:57Z

Description

expand the account section, if only one account is configured
show quick access and saved searches in client location picker in share extension to get more access to save locations
automatically expand quick access folder in share sheet

Related Issue

https://github.com/owncloud/enterprise/issues/6134

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
Added an issue with details about all relevant changes in the iOS documentation repository.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
Added changelog files for the fixed issues in folder changelog/unreleased

…pace for the logo image

Co-authored-by: Michael Stingl <[email protected]>

* Remove old PLIST examples * move ownCloud.online theme + assets * move EMM assets * Adjust Fastfile for moved themes + assets * updated to Xcode 14.3 * move all app resources to the correct place in one copy command * updated to 14.3.1 --------- Co-authored-by: Michael Stingl <[email protected]> Co-authored-by: Matthias Hühne <[email protected]>

- added accessibility label to the logo image

…erprise#5889)

- add support for RGBA hex values to CSS

…screen background (#1264) * - add background image to welcome screen - add support for RGBA hex values to CSS * Assets.xcassets/AppIcon.appiconset generated with fastlane * align icon name with branding --------- Co-authored-by: Felix Schwarz <[email protected]> Co-authored-by: Michael Stingl <[email protected]>

…cords for colors, incl. a set of system colors - ThemeCollection: add system colors (f.ex. UIColor.systemBlue as `os.color.blue`) and theme base colors (as `theme.color.light` and `theme.color.dark`) to CSS object

…branding

…o dark

- add permanent logo branding to top of the view - make branding elements use same CSS selectors as welcome screen - ComposedMessageView: make CSS selectors extension public - RoundCornerBackgroundView: add new .fillImage property that allows filling the view with an image with "scaleAspectFill" contentMode

…nded builds

…uld fix crash reported in #1245 (comment))

…into milestone/12.0.3

…lor and label was not readable, if lightBrandColor was similar to #000000

…ErrorForNonExistentItemWithIdentifier:]` for the case that iOS (illegally) passes in a nil `identifier`, leading to a crash in said NSError method

…#1249)

…alue could be determined for the first time (fixing crash/finding 8 in #1274)

- change officeFileFillColor to documentFileFillColor

- expand the account section, if only one account is configured - show quick access and saved searches in client location picker in share extension

…s folder in the share sheet picker view

ownCloudAppShared/Client/Account/Controller/AccountController.swift

…swift Co-authored-by: Felix Schwarz <[email protected]>

jesmrec · 2023-12-05T08:40:55Z

(1)

Menu is only expanded the first time. Follow these steps:

Add only one account to device
Open Photos (or any other app to share files)
Select some pictures to share with oC -> Picker displayed
Cancel
Repeat step 3.

Current: menu not expanded:

RPReplay_Final1701765477.MP4

Expected: menu expanded, no matter hay many times

iPhoneXR v17.2
23b11e12

cc @hosy

michaelstingl · 2023-12-11T09:53:08Z

Current: menu not expanded:

@felix-schwarz could you have another 👀 ?

…lectionViewAction - CollectionViewAction: add missing parts in implementation for .expand() to expand cells, add status awareness (double expansion collapses them again) - CollectionViewSection: check cell expansion status before expanding the cell (double expansion collapses them again)

CLAassistant · 2023-12-11T11:16:37Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hosy
❌ felix-schwarz
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

felix-schwarz · 2023-12-11T11:17:56Z

@hosy @michaelstingl @jesmrec I fixed issue (1) in ecf3610

jesmrec · 2023-12-13T10:24:43Z

Checked the fix, please take a look to the following video ( taken with ecf3610a - 57b05c6):

RPReplay_Final1702462392.MP4

First time sharing, menu is expanded but then collapsed
Second time, Connecting in the status bar ant the app closes itself
Third time, same as first.

I tested many times, and also worked fine in some of then. Not sure if there are kind of race condition or similar that causes such weird effect. If logs or any other info helps, i will catch.

Tested with iPhoneXR 17.2

- add new option .allowHidingNavigationBar to allow fine-tuning hiding of navigation bar (fixes optical issue when using ClientLocationPicker within the app, while allowing customization through ShareExtensionViewController) - apply same fixes to setting up sectionDataSource as were previously applied for the app's sidebar - ShareExtensionViewController: - add minor delay before opening single account connection - make use of ClientLocationPicker.allowHidingNavigationBar to force navigation bar even on first level - AccountController: clean-up and optimizations

felix-schwarz · 2023-12-15T10:57:09Z

@jesmrec I had another look and it seems those were weird timing issues, which I hope to have addressed with b828930. Please have another look.

jesmrec · 2023-12-15T14:15:34Z

works much better, but i still see that is not totally correct. Sometimes is not expanded

RPReplay_Final1702462392.mp4

52c4fc7
74156a0

felix-schwarz · 2024-02-28T21:25:35Z

Superseded by changes in #1320.

hosy and others added 30 commits July 11, 2023 11:33

removed the logo label from the sidebar navigation bar to have more s…

5313248

…pace for the logo image

- fix #1254

a95bb44

Example JSON + README (#1255)

e0d8c18

Co-authored-by: Michael Stingl <[email protected]>

- FileProvider: fix enumerator queue completion slowdown/blocking

5d54b5d

- show vendor label in the sidebar if app is unbranded

e14352c

- added accessibility label to the logo image

- FileProvider cleanup and additional debug logging

0571ec7

- BottomButtonBar: avoid collapse of selectButton (fixes owncloud/ent…

9a3e5ef

…erprise#5889)

- add background image to welcome screen

fed83fd

- add support for RGBA hex values to CSS

- change welcome screen background default color from dark to bright

b4c5320

- BookmarkViewController: add .bookmarkEditor CSS selector

3e7198b

Merge branch 'fix/sidebar-logo' into experimental/branding

e596ab7

- ThemeCSS: add support for $cssSelector.cssProperty

3346666

- change welcome screen background default color from dark to bright

abe25cb

Assets.xcassets/AppIcon.appiconset generated with fastlane

1ea7a36

rename vanilla appiconset again for fastlane changes

fa5b296

Merge branch 'experimental/branding-css-syscolors' into experimental/…

f0e779b

…branding

Vanilla: change welcome screen background default color from bright t…

5c7db31

…o dark

- BookmarkViewController: remove table view background image from bra…

a9ca511

…nded builds

- RoundCornerBackgroundView: fix bug in sizeThatFills()

ded3a57

- DisplayViewController: handle nil OCQueryChangeSet.queryResult (sho…

95522b0

…uld fix crash reported in #1245 (comment))

fixed missing translation strings or localized function

c4e0d89

Merge branch 'milestone/12.0.3' of https://github.com/owncloud/ios-app …

de9ab8f

…into milestone/12.0.3

fixed bug in sidebar: label color got the same color as background co…

ba99ed1

…lor and label was not readable, if lightBrandColor was similar to #000000

- FileProviderExtension: add safeguards around `[NSError fileProvider…

7986210

…ErrorForNonExistentItemWithIdentifier:]` for the case that iOS (illegally) passes in a nil `identifier`, leading to a crash in said NSError method

[fix/overlapping-sharing-buttons] Overlapping Sharing Buttons (#1248)

9a3f828

[fix/passcode-device-enforced] MDM Parameter - Enforce Passcode Setup (…

7c7115b

…#1249)

felix-schwarz and others added 5 commits November 2, 2023 11:30

- DataSourceCondition: only perform initial call after a .fulfilled v…

166a514

…alue could be determined for the first time (fixing crash/finding 8 in #1274)

- ThemeCollection: correctly map office document color

9a4fc65

- change officeFileFillColor to documentFileFillColor

#6134

fe051c2

- expand the account section, if only one account is configured - show quick access and saved searches in client location picker in share extension

added configuration parameter to automatically expand the Quick Acces…

b37f301

…s folder in the share sheet picker view

Calens changelog updated

8bd905d

hosy requested review from felix-schwarz and jesmrec November 20, 2023 11:58

jesmrec mentioned this pull request Nov 21, 2023

[RELEASE] 12.1 #1300

Closed

36 tasks

felix-schwarz requested changes Nov 23, 2023

View reviewed changes

ownCloudAppShared/Client/Account/Controller/AccountController.swift Outdated Show resolved Hide resolved

michaelstingl linked an issue Nov 27, 2023 that may be closed by this pull request

[FEATURE REQUEST] Skip account selection when only a one account is configured #1288

Closed

9 tasks

Update ownCloudAppShared/Client/Account/Controller/AccountController.…

23b11e1

…swift Co-authored-by: Felix Schwarz <[email protected]>

hosy requested a review from felix-schwarz November 28, 2023 15:29

felix-schwarz approved these changes Nov 29, 2023

View reviewed changes

Configuration documentation updated

52c4fc7

michaelstingl added this to the 12.2-Next milestone Dec 18, 2023

delete-merged-branch bot deleted the branch milestone/12.1 January 29, 2024 14:27

Base automatically changed from feature/account-wizard to milestone/12.1 January 29, 2024 16:56

delete-merged-branch bot deleted the branch milestone/12.1 January 30, 2024 15:36

felix-schwarz mentioned this pull request Feb 28, 2024

[feature/better-sidebar] Improved sidebar with account-wide search #1320

Merged

3 tasks

felix-schwarz closed this Feb 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature/share-extension-account-items] Expanded Single Account / Additional Items #1296

[feature/share-extension-account-items] Expanded Single Account / Additional Items #1296

hosy commented Nov 16, 2023 •

edited

Loading

jesmrec commented Dec 5, 2023 •

edited

Loading

michaelstingl commented Dec 11, 2023

CLAassistant commented Dec 11, 2023

felix-schwarz commented Dec 11, 2023

jesmrec commented Dec 13, 2023

felix-schwarz commented Dec 15, 2023

jesmrec commented Dec 15, 2023

felix-schwarz commented Feb 28, 2024

[feature/share-extension-account-items] Expanded Single Account / Additional Items #1296

[feature/share-extension-account-items] Expanded Single Account / Additional Items #1296

Conversation

hosy commented Nov 16, 2023 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

jesmrec commented Dec 5, 2023 • edited Loading

(1)

michaelstingl commented Dec 11, 2023

CLAassistant commented Dec 11, 2023

felix-schwarz commented Dec 11, 2023

jesmrec commented Dec 13, 2023

felix-schwarz commented Dec 15, 2023

jesmrec commented Dec 15, 2023

felix-schwarz commented Feb 28, 2024

hosy commented Nov 16, 2023 •

edited

Loading

jesmrec commented Dec 5, 2023 •

edited

Loading