[feature/new-issue-view] New Issue view / presentation #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ConnectionIssueViewController: - compare against certificate stored in the bookmark where available - remove text-based rendering via CertificateViewController (and remove the class), replace it with the standard certificate view controller - adaptions to new ThemeCertificateViewController initialization where needed - update SDK
- remove IssuesViewController, ConnectionIssueViewController, IssuesPresentationAnimator and IssuesDismissalAnimator - create modern replacement leveraging existing code: IssuesCardViewController - migrate code from ConnectionIssueViewController to IssuesCardViewController - add new helper function to compare DisplayIssues issue levels without having to use .rawValue - MoreViewController - becomes FrameViewController - adds the ability to also add a footer view - cleanup: removal of unused properties and initializers - StaticTableViewRow: add .messageStyle support - ThemeTableViewCell: add .messageStyle support and add additional CellStyler block API based on also new CellStyleSet - AlertView: - add support for .accessibilityIdentifier - add option for custom .contentPadding - add button-only mode - CardPresentationController: - ensure .dismissable is actually respected - fix premature release of CardTransitionDelegate that could lead to normal presentation rather than as a card
|
|
mneuwert
approved these changes
Jan 24, 2021
felix-schwarz
changed the base branch from
feature/tls-diff
to
milestone/11.5
|
QA checks iPhone
iPad
|
(1)The
text does not fit correctly to the background yellow chart. If portrait mode is set again after landscape:
iPhoneXR iOS14 |
- FrameViewController: include table background color pin theming support - ThemeTableViewCell: - support recreation of labels and custom layout of these labels - add primaryTextLabel and primaryDetailTextLabel accessors to access text labels irrespective of whether they are system-provided or recreated - StaticTableViewRow - add support for recreated labels and their custom layout - IssuesCardViewController - replace usage of constraints in CardCellBackgroundView with auto resized views (fixes auto layout constraint warnings) - switch to using primaryTextLabel and primaryDetailTextLabel and a custom recreatedLabelLayout
|
Totally fixed. Approved on my side |
jesmrec
approved these changes
Feb 1, 2021
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As fixing an iPad layout issue in the old issues view proved too cumbersome, I've replaced the entire implementation with a new issue view, based on code already there and in use for cards and tables.
The result provides a more modern look, is consistent with the rest of the app and shrinks the code base by ~ 220 lines of code.
Screenshots (if appropriate):
Types of changes
QA
Checklist: #874 (comment)
Bugs & improvements: