Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix/bookmark-name] Fix bookmark name editing #877

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

felix-schwarz
Copy link
Contributor

Description

When editing bookmarks:

  • if a name was set, it wasn't shown in the edit interface
  • bookmark name edits/additions would get lost
  • bookmark name edits would not be presented in the list unless scrolling out of view and back in

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

… edits/additions would get lost; name edits would not be presented in the list unless scrolling out of view and back in.
@felix-schwarz felix-schwarz added this to the 11.5.0-Current milestone Jan 25, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jesmrec
Copy link
Contributor

jesmrec commented Jan 26, 2021

Approved

@hosy hosy added the Approved by QA Approved by QA label Jan 26, 2021
@hosy hosy merged commit ce35c8b into milestone/11.5 Jan 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/bookmark-name branch January 26, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants