[fix/pdf-thumbnailview-position] PDF thumbnail view position on the iPad #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added orientation changed notification to recreate the constrains, when the device was rotated
mneuwert
approved these changes
Feb 28, 2021
(1)
then it should only affect iPad. I have check in iPhone, and i detected a weird behaviour in portrait mode: the position of the thumbnail list changes from bottom to right at the time you move the device (not necessary to change orientation): VID_20210301_095612.mp4 |
|
@jesmrec finding (1) is fixed and you can have a look again. Thank you! |
|
unfortunately, i still reproduce (1) with commit |
|
@jesmrec hopefully with the latest commit it is solved. |
|
Not it is correctly fixed. Approved on my side. |
jesmrec
approved these changes
Mar 1, 2021
hosy
added a commit
that referenced
this pull request
Mar 3, 2021
* Preparing new version: changed version and build number to 11.5.2 and 188 * Add Themeable support to the Acknowledgements (#900) * [feature/flat-mdm-settings] Support for MDM setting hierarchies with flat keys (#904) * - automatic termination + relaunch by notification on MDM changes push - fix indentation * - react to setting changes pushed via MDM differently, in a two-step process - first notify the user about the changes - if the user taps the notification, schedule a relaunch notification and then quit - if the user taps the relaunch notification, the app is launched - request authorization to post notifications if needed * [fix/pdf-thumbnailview-position] PDF thumbnail view position on the iPad (#905) * Fixing the thumbnail view position on the iPad in portrait view - added orientation changed notification to recreate the constrains, when the device was rotated * added changelog issue * Calens changelog updated * fixed QA finding (jumpy thumbnail view on iPhone) * isPortrait mode is not working and removed it with size class Co-authored-by: hosy <[email protected]> * [fix/collapsible-progress-bar-position-flex] Collapse Progress Bar in Detail View (#911) * Accessing hyper links in PDF view (#913) * Updated release notes for version 11.5.2 * Calens changelog updated * [feature/owncloud-online-screentshots] Create Screenshots for Branded Builds with Fastlane (#912) * updated In-App release notes with marketing fix * moved calens changelog files into release folder * Calens changelog updated * updated SDK to latest master commit Co-authored-by: Felix Schwarz <[email protected]> Co-authored-by: hosy <[email protected]> Co-authored-by: Michael Neuwert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the position of the PDF thumbnail view on the iPad from the bottom to the right position.
Related Issue
Motivation and Context
There are some reasons why the right position makes more sense:
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
QA