-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add creation time to the permission object #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me. We should just add a note that this is a libregraph property only. Similar to what is done for the createLink
request body (driveItemCreateLink)
api/openapi-spec/v1.0.yaml
Outdated
@@ -4963,6 +4963,11 @@ components: | |||
description: An optional expiration date which limits the permission in time. | |||
format: date-time | |||
nullable: true | |||
creationDateTime: | |||
type: string | |||
description: An optional creation date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please at a note here, that this is libregraph only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I was referring to add the note the the description. Like we do e.g. here:
https://github.com/owncloud/libre-graph-api/blob/main/api/openapi-spec/v1.0.yaml#L4222
5db5f93
to
cc78aac
Compare
api/openapi-spec/v1.0.yaml
Outdated
@@ -4963,6 +4963,11 @@ components: | |||
description: An optional expiration date which limits the permission in time. | |||
format: date-time | |||
nullable: true | |||
creationDateTime: | |||
type: string | |||
description: An optional creation date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I was referring to add the note the the description. Like we do e.g. here:
https://github.com/owncloud/libre-graph-api/blob/main/api/openapi-spec/v1.0.yaml#L4222
cc78aac
to
bb37690
Compare
the c-time is not part of the official ms spec, that means were extending the permission object with a creationDateTime object property.
not sure how we proceed with that (not part of the official spec), lets discuss it here!
Needed by: owncloud/ocis#8749