settings: Remove deprecated filesystem backend

We changed the default to `metadata` before the 2.0 release. This PR
alos removes the associated `SETTINGS_STORE_TYPE` and
`SETTINGS_DATA_PATH` settings as they are no longer needed with
`metadata` as the only available backend.

changelog/unreleased/remove-deprecated-settings-backend.md

@@ -0,0 +1,6 @@
+Change: The `filesystem` backend for the settings service has been removed
+
+The only remaining backend for the settings service is `metadata`, which has been the
+default backend since ocis 2.0
+
+https://github.com/owncloud/ocis/pull/9138

services/settings/README.md

@@ -12,12 +12,7 @@ The settings service is currently used for managing the:
 
 As an example, user profile settings that can be changed in the Web UI must be persistent.
 
-The settings service supports two different backends for persisting the data. The backend can be set via the `SETTINGS_STORE_TYPE` environment variable. Supported values are:
-
-*   `metadata`: The default. This backend persists the settings data via the `storage-system` service.
-*   `filesystem`: (deprecated) This backend persists the settings data in a directory on the local filesystem.
-  The directory can be configured with `SETTINGS_DATA_PATH`. This backend is **not** suitable for running
-  multiple intances of the `settings` service in a scale-out deployment and was therefore deprecated.
+The settings service persists the settings data via the `storage-system` service.
 
 <!--- Note: The diagramm is outdate, leaving it here for a future rework
 The diagram shows how the settings service integrates into oCIS:
@@ -37,7 +32,7 @@ graph TD
 
 ## Caching
 
-When using `SETTINGS_STORE_TYPE=metadata`, the `settings` service caches the results of queries against the storage backend to provide faster responses. The content of this cache is independent of the cache used in the `storage-system` service as it caches directory listing and settings content stored in files.
+The `settings` service caches the results of queries against the storage backend to provide faster responses. The content of this cache is independent of the cache used in the `storage-system` service as it caches directory listing and settings content stored in files.
 
 The store used for the cache can be configured using the `SETTINGS_CACHE_STORE` environment variable. Possible stores are:
   -   `memory`: Basic in-memory store and the default.

services/settings/pkg/config/config.go

@@ -25,8 +25,6 @@ type Config struct {
 	GRPCClientTLS *shared.GRPCClientTLS `yaml:"grpc_client_tls"`
 	GrpcClient    client.Client         `yaml:"-"`
 
-	StoreType   string                `yaml:"store_type" env:"SETTINGS_STORE_TYPE" desc:"Store type configures the persistency driver. Supported values are 'metadata' and 'filesystem'. Note that the value 'filesystem' is considered deprecated." introductionVersion:"pre5.0"`
-	DataPath    string                `yaml:"data_path" env:"SETTINGS_DATA_PATH" desc:"The directory where the filesystem storage will store ocis settings. If not defined, the root directory derives from $OCIS_BASE_DATA_PATH:/settings." introductionVersion:"pre5.0"`
 	Metadata    Metadata              `yaml:"metadata_config"`
 	BundlesPath string                `yaml:"bundles_path" env:"SETTINGS_BUNDLES_PATH" desc:"The path to a JSON file with a list of bundles. If not defined, the default bundles will be loaded." introductionVersion:"pre5.0"`
 	Bundles     []*settingsmsg.Bundle `yaml:"-"`

services/settings/pkg/config/defaults/defaultconfig.go

@@ -3,11 +3,9 @@ package defaults
 import (
 	"encoding/json"
 	"os"
-	"path"
 	"strings"
 	"time"
 
-	"github.com/owncloud/ocis/v2/ocis-pkg/config/defaults"
 	"github.com/owncloud/ocis/v2/ocis-pkg/structs"
 	"github.com/owncloud/ocis/v2/services/settings/pkg/config"
 	rdefaults "github.com/owncloud/ocis/v2/services/settings/pkg/store/defaults"
@@ -49,8 +47,6 @@ func DefaultConfig() *config.Config {
 			Addr:      "127.0.0.1:9191",
 			Namespace: "com.owncloud.api",
 		},
-		StoreType:               "metadata", // use metadata or filesystem
-		DataPath:                path.Join(defaults.BaseDataPath(), "settings"),
 		SetupDefaultAssignments: false,
 		Metadata: config.Metadata{
 			GatewayAddress: "com.owncloud.api.storage-system",

services/settings/pkg/service/v0/service.go

@@ -17,7 +17,6 @@ import (
 	"github.com/owncloud/ocis/v2/services/settings/pkg/config"
 	"github.com/owncloud/ocis/v2/services/settings/pkg/settings"
 	"github.com/owncloud/ocis/v2/services/settings/pkg/store/defaults"
-	filestore "github.com/owncloud/ocis/v2/services/settings/pkg/store/filesystem"
 	metastore "github.com/owncloud/ocis/v2/services/settings/pkg/store/metadata"
 	merrors "go-micro.dev/v4/errors"
 	"go-micro.dev/v4/metadata"
@@ -40,17 +39,7 @@ func NewService(cfg *config.Config, logger log.Logger) settings.ServiceHandler {
 		logger: logger,
 	}
 
-	switch cfg.StoreType {
-	default:
-		fallthrough
-	case "metadata":
-		service.manager = metastore.New(cfg)
-	case "filesystem":
-		fmt.Println("WARNING: filesystem store is deprecated and will be removed in the future. Please use metadata store instead.")
-		service.manager = filestore.New(cfg)
-		// TODO: if we want to further support filesystem store it should use default permissions from store/defaults/defaults.go instead using this duplicate
-		service.RegisterDefaultRoles()
-	}
+	service.manager = metastore.New(cfg)
 	return service
 }
 
@@ -101,45 +90,6 @@ func (g Service) CheckPermission(ctx context.Context, req *cs3permissions.CheckP
 	}, nil
 }
 
-// RegisterDefaultRoles composes default roles and saves them. Skipped if the roles already exist.
-func (g Service) RegisterDefaultRoles() {
-	// FIXME: we're writing default roles per service start (i.e. twice at the moment, for http and grpc server). has to happen only once.
-	for _, role := range generateBundlesDefaultRoles() {
-		bundleID := role.Extension + "." + role.Id
-		// check if the role already exists
-		bundle, _ := g.manager.ReadBundle(role.Id)
-		if bundle != nil {
-			g.logger.Debug().Str("bundleID", bundleID).Msg("bundle already exists. skipping.")
-			continue
-		}
-		// create the role
-		_, err := g.manager.WriteBundle(role)
-		if err != nil {
-			g.logger.Error().Err(err).Str("bundleID", bundleID).Msg("failed to register bundle")
-		}
-		g.logger.Debug().Str("bundleID", bundleID).Msg("successfully registered bundle")
-	}
-
-	for _, req := range generatePermissionRequests() {
-		_, err := g.manager.AddSettingToBundle(req.GetBundleId(), req.GetSetting())
-		if err != nil {
-			g.logger.Error().
-				Err(err).
-				Str("bundleID", req.GetBundleId()).
-				Interface("setting", req.GetSetting()).
-				Msg("failed to register permission")
-		}
-	}
-
-	if g.config.SetupDefaultAssignments {
-		for _, req := range g.defaultRoleAssignments() {
-			if _, err := g.manager.WriteRoleAssignment(req.AccountUuid, req.RoleId); err != nil {
-				g.logger.Error().Err(err).Msg("failed to register role assignment")
-			}
-		}
-	}
-}
-
 // TODO: check permissions on every request
 
 // SaveBundle implements the BundleServiceHandler interface