Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Martin <[email protected]>
  • Loading branch information
rhafer and mmattel committed Jul 2, 2024
1 parent 3ca1a97 commit d1f28f8
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions services/proxy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,16 @@ service using the claim values configured in
`PROXY_AUTOPROVISION_CLAIM_DISPLAYNAME`.

If the user does already exist, the proxy will check if the user's email or
displayname has changed and update those accordingly via `graph` service.
displayname has changed and updates those accordingly via `graph` service.

Next, the proxy will check if the user is a member of the groups configured in
`PROXY_AUTOPROVISION_CLAIM_GROUPS`. It will add the user to the groups listed
in there and remove it from all other groups that it is currently a member of.
Groups that do not exist yet will be created. Note: This can be a somewhat
costly operation, especially if the user is a member of a large number of
via the OIDC claim that holds the groups defined in the envvar and removes it from
all other groups that he is currently a member of.
Groups that do not exist in the external IDP yet will be created. Note: This can be a
somewhat costly operation, especially if the user is a member of a large number of
groups. If the group memberships of a user are changed in the IDP after the
first login it can take up to 5 minutes until the changes are reflected in
ownCloud Infinite Scale.
first login, it can take up to 5 minutes until the changes are reflected in Infinite Scale.

## Automatic Quota Assignments

Expand Down Expand Up @@ -150,9 +150,8 @@ is unset.
When `PROXY_ROLE_ASSIGNMENT_DRIVER` is set to `oidc` the role assignment for a user will happen
based on the values of an OpenID Connect Claim of that user. The name of the OpenID Connect Claim to
be used for the role assignment can be configured via the `PROXY_ROLE_ASSIGNMENT_OIDC_CLAIM`
environment variable. It is also possible to defe ine a mapping of claim values to role names defined
in ownCloud Infinite Scale via a `yaml` configuration. See the following `proxy.yaml` snippet for an
example.
environment variable. It is also possible to define a mapping of claim values to role names defined
in Infinite Scale via a `yaml` configuration. See the following `proxy.yaml` snippet for an example.

```yaml
role_assignment:
Expand Down

0 comments on commit d1f28f8

Please sign in to comment.