Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sharing-ng] update/disable virtual space returns 500 error #7881

Closed
individual-it opened this issue Dec 5, 2023 · 2 comments · Fixed by #8235
Closed

[sharing-ng] update/disable virtual space returns 500 error #7881

individual-it opened this issue Dec 5, 2023 · 2 comments · Fixed by #8235
Assignees
@rhafer
Labels
Priority:p3-medium Normal priority Type:Bug

Comments

@individual-it
Copy link
Member

Describe the bug

Trying to send a PATCH or DELETE to a virtual space (Shares) throws an 500 error

Expected behavior

405 HTTP response

Actual behavior

HTTP 500
{"error":{"code":"generalException","innererror":{"date":"2023-12-05T09:26:13Z","request-id":"eb2eb607293d/ADjidDU61G-030279"},"message":"grpc error"}}
@individual-it individual-it mentioned this issue Dec 5, 2023
Merged
@individual-it
Copy link
Member Author

See also #6993

@dragonchaser dragonchaser added the Priority:p3-medium Normal priority label Jan 15, 2024
@rhafer rhafer self-assigned this Jan 17, 2024
rhafer added a commit to rhafer/ocis that referenced this issue Jan 17, 2024
@rhafer
graph/drives: Fix status code for PATCH/DELETE on drives don't allow …
a915c90 
…them

Return a 405 Status when UpdateSpace() or DeleteSpace() are not implemented
in the backend for a certain type of drive (e.g. the virtual mountpoint drives
created for shares).

Fixes: owncloud#7881
@rhafer rhafer mentioned this issue Jan 17, 2024
Merged
rhafer added a commit to rhafer/ocis that referenced this issue Jan 17, 2024
@rhafer
graph/drives: Fix status code for PATCH/DELETE on drives don't allow …
a4b5b80 
…them

Return a 405 Status when UpdateSpace() or DeleteSpace() are not implemented
in the backend for a certain type of drive (e.g. the virtual mountpoint drives
created for shares).

Fixes: owncloud#7881
@rhafer
Copy link
Contributor

rhafer commented Jan 17, 2024

#8235 fixes the reponse code for now.

AFAIK DELETE /v1.0/drives/<drive-id-of-a-received-share> is supposed to be use for unmounting a share at some point. (Probably part of #7885)

rhafer added a commit to rhafer/ocis that referenced this issue Jan 17, 2024
@rhafer
graph/drives: Fix status code for PATCH/DELETE on drives don't allow …
1503b13 
…them

Return a 405 Status when UpdateSpace() or DeleteSpace() are not implemented
in the backend for a certain type of drive (e.g. the virtual mountpoint drives
created for shares).

Fixes: owncloud#7881
@rhafer rhafer closed this as completed in f3ed318 Jan 22, 2024
ownclouders pushed a commit that referenced this issue Jan 22, 2024
@rhafer
graph/drives: Fix status code for PATCH/DELETE on drives don't allow …
ba3587e 
…them

Return a 405 Status when UpdateSpace() or DeleteSpace() are not implemented
in the backend for a certain type of drive (e.g. the virtual mountpoint drives
created for shares).

Fixes: #7881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
Priority:p3-medium Normal priority Type:Bug
Projects
Infinite Scale Team Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

graph/drives: Fix status code for PATCH/DELETE on drives not allowing them rhafer/ocis
3 participants
@rhafer @dragonchaser @individual-it