Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phoenix 0.29.0 #1034

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Update phoenix 0.29.0 #1034

merged 3 commits into from
Dec 8, 2020

Conversation

LukasHirt
Copy link
Contributor

No description provided.

@LukasHirt LukasHirt self-assigned this Dec 8, 2020
kulmann
kulmann requested changes Dec 8, 2020
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated assets are broken. Could you please run cd ocis-phoenix && rm -r assets && make generate?

@LukasHirt
Copy link
Contributor Author

generated assets are broken. Could you please run cd ocis-phoenix && rm -r assets && make generate?

Done. I've changed slightly the makefile to run even if the assets folder exists and to delete it before pulling the assets.

@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kulmann
kulmann approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kulmann
Copy link
Member

kulmann commented Dec 8, 2020

Done. I've changed slightly the makefile to run even if the assets folder exists and to delete it before pulling the assets.

Awesome! :-)

@LukasHirt LukasHirt merged commit 507ad7b into master Dec 8, 2020
@LukasHirt LukasHirt deleted the update-phoenix-0.29.0 branch December 8, 2020 09:35
ownclouders pushed a commit that referenced this pull request Dec 8, 2020
commit 507ad7b
aa69618 
Merge: 5373eb9 3fbe506
Author: Lukas Hirt <[email protected]>
Date:   Tue Dec 8 10:35:23 2020 +0100

    Merge pull request #1034 from owncloud/update-phoenix-0.29.0
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@LukasHirt LukasHirt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LukasHirt @kulmann