Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all paths configurable and default to a subdir of the /var/tmp/ocis #1080

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Dec 12, 2020

Aligned all services to use a subdir of /var/tmp/ocis/ by default. Also made some missing temp paths configurable via env vars and config flags.

This does change default paths and also two env vars which were missing the STORAGE_ prefix. Nothing critical.

related: #1048

@butonic butonic changed the title Make all paths configurable and default to Make all paths configurable and default to a subdir of the /var/tmp/ocis Dec 12, 2020

Aligned all services to use a subdir of `/var/tmp/ocis/` by default. Also made some missing temp paths configurable via env vars and config flags.

https://github.com/owncloud/ocis/pulls/1080
Copy link
Member Author

@butonic butonic Dec 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is wrong with the change log? Does it really require an issue link?!?

file ../changelog/unreleased/make-all-paths-configurable.md: primary issue ID not found
exit status 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that using backticks might be problem, specially in line 1. That ends with a backtick, and maybe there is an edge-case problem with that sort of thing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd guess the same. The structure of the changelog looks ok - a primary URL is required, but it can be any URL (issue, PR, third party resource, ...).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had .../pulls/1080 instead of .../pull/1080 in it ... which really does not exist ... 😞

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
Copy link
Member Author

butonic commented Dec 14, 2020

wtf https://drone.owncloud.com/owncloud/ocis/2198/38/4 :

2020-12-14 07:56:56  file=web/service.go:258 level=info Listening on [::]:9100 | 3s
-- | --
39 | 2020-12-14 07:56:56  file=api/api.go:285 level=info service=api Registering API Default Handler at / | 3s
40 | 2020-12-14 07:56:56  file=http/http.go:90 level=info service=api HTTP API Listening on [::]:8080 | 3s
41 | 2020-12-14 07:56:56  [email protected]/service.go:200 level=info service=api Starting [service] com.owncloud.api | 3s
42 | 2020-12-14 07:56:56  file=grpc/grpc.go:864 level=info service=api Server [grpc] Listening on [::]:41995 | 3s
43 | 2020-12-14 07:56:56  file=grpc/grpc.go:697 level=info service=api Registry [mdns] Registering node: com.owncloud.api-2ecaa65c-0c38-4e8b-a40b-46dc4be530e0 | 3s
44 | 2020-12-14T07:56:56Z WRN policy-selector not configured. Will always use first policy: 'reva' service=proxy | 3s
45 | 2020-12-14T07:56:56Z WRN basic auth enabled, use only for testing or development service=proxy | 3s
46 | 2020-12-14T07:56:56Z WRN No tls certificate provided, using a generated one service=proxy | 3s
47 | 2020-12-14 07:56:56  [email protected]/service.go:200 level=info Starting [service] com.owncloud.api.settings | 3s
48 | 2020-12-14 07:56:56  file=grpc/grpc.go:864 level=info Server [grpc] Listening on [::]:9191 | 3s
49 | 2020-12-14 07:56:56  file=grpc/grpc.go:697 level=info Registry [mdns] Registering node: com.owncloud.api.settings-df6adc00-5d48-4566-a264-3b43fefbc7b3 | 3s
50 | 2020-12-14 07:56:56  file=web/service.go:258 level=info Listening on [::]:9110 | 3s
51 | 2020-12-14 07:56:56  file=web/service.go:258 level=info Listening on [::]:9190 | 3s
52 | 2020-12-14 07:56:56  [email protected]/service.go:200 level=info service=registry Starting [service] com.owncloud.registry | 3s
53 | 2020-12-14 07:56:56  file=grpc/grpc.go:864 level=info service=registry Server [grpc] Listening on [::]:8000 | 3s
54 | 2020-12-14 07:56:56  file=grpc/grpc.go:697 level=info service=registry Registry [mdns] Registering node: com.owncloud.registry-25eac54e-2d66-4b50-b0a0-529cc3104803 | 3s
55 | 2020-12-14T07:56:56Z ERR Failed to start server error="listen tcp 0.0.0.0:9100: bind: address already in use" service=web transport=http | 4s
56 | process [web] exited with code: 1 | 4s
57 | 2020-12-14 07:56:56  file=web/service.go:258 level=info Listening on [::]:9220 | 4s
58 | 2020-12-14 07:56:56  [email protected]/service.go:200 level=info Starting [service] com.owncloud.api.thumbnails | 4s
59 | 2020-12-14 07:56:56  file=grpc/grpc.go:864 level=info Server [grpc] Listening on [::]:9185 | 4s
60 | 2020-12-14 07:56:56  file=grpc/grpc.go:697 level=info Registry [mdns] Registering node: com.owncloud.api.thumbnails-58ae1724-4d5e-470b-a88d-5b053308a4eb | 4s
61 | 2020-12-14 07:56:56  file=web/service.go:258 level=info Listening on [::]:9115 | 4s
62 | 2020-12-14 07:56:57  file=web/service.go:258 level=info Listening on [::]:9200 | 4s
63 | watching accounts | 5s
64 | watching storage-sharing | 5s
65 | 2020-12-14T07:56:58Z FTL could not initialize service handler error="rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:9215: connect: connection refused\"" service=accounts | 5s
66 | process [accounts] exited with code: 1

already in use ... hm phoenix -> web rename ?

I restarted the build ... seems like a hiccup.

@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit e968cb0 into master Dec 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the make-all-paths-configurable branch December 14, 2020 11:16
ownclouders pushed a commit that referenced this pull request Dec 14, 2020
Merge: ee7b321 901be34
Author: Benedikt Kulmann <[email protected]>
Date:   Mon Dec 14 12:16:32 2020 +0100

    Merge pull request #1080 from owncloud/make-all-paths-configurable

    Make all paths configurable and default to a subdir of the /var/tmp/ocis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants