Introduce permission checks for WRITE access via http #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
kulmann
force-pushed
the
settings-permission-checks
branch
from
cdeafa2
to
0705a36
Compare
kulmann
force-pushed
the
settings-permission-checks
branch
from
657a6b9
to
633391e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
butonic
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces permission checks for the write access http endpoints, so this already improves security.
There is another issue, that users can save values of other users. This is not tackled, yet. Could happen in a separate PR if we want to merge this one here quickly.