Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web to 1.0.1 #1191

Merged
merged 7 commits into from
Jan 13, 2021
Merged

Update web to 1.0.1 #1191

merged 7 commits into from
Jan 13, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jan 8, 2021

Update web to most recent release 1.0.1. This also brings a feature which was already used in the tests, therefor we can remove some expected failures:
Fixes #1197

@phil-davis
Copy link
Contributor

Some strange API test failure: https://drone.owncloud.com/owncloud/ocis/2636/19/7

  Scenario Outline: Creating a share of a file with a user                                                 # /drone/src/tests/acceptance/features/apiBasic/createShareToSharesFolder.feature:4
    Given the administrator has set the default folder for received shares to "Shares"                     # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And auto-accept shares has been disabled                                                               # FeatureContext::autoAcceptSharesHasBeenDisabled()
    And using OCS API version "<ocs_api_version>"                                                          # FeatureContext::usingOcsApiVersion()
    And user "Alice" has been created with default attributes and without skeleton files                   # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt"        # FeatureContext::userHasUploadedAFileWithContentTo()
    And user "Brian" has been created with default attributes and without skeleton files                   # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    When user "Alice" shares file "textfile0.txt" with user "Brian" using the sharing API                  # FeatureContext::userSharesFileWithUserUsingTheSharingApi()
    And user "Brian" accepts share "/textfile0.txt" offered by user "Alice" using the sharing API          # FeatureContext::userReactsToShareOfferedBy()
    Then the HTTP status code should be "200"                                                              # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the content of file "/Shares/textfile0.txt" for user "Brian" should be "ownCloud test text file 0" # FeatureContext::contentOfFileForUserShouldBe()

    Examples:
      | ocs_api_version |
      | 1               |
        Sharing::userReactsToShareOfferedBy could not find share /textfile0.txt, offered by Alice to Brian
        Failed asserting that null is not null.
      | 2               |
        Sharing::userReactsToShareOfferedBy could not find share /textfile0.txt, offered by Alice to Brian
        Failed asserting that null is not null.

How is that related to the changes in this PR???

The PR needs a rebase anyway. Maybe that will help.

@kulmann
Copy link
Member Author

kulmann commented Jan 13, 2021

Some strange API test failure: https://drone.owncloud.com/owncloud/ocis/2636/19/7

  Scenario Outline: Creating a share of a file with a user                                                 # /drone/src/tests/acceptance/features/apiBasic/createShareToSharesFolder.feature:4
    Given the administrator has set the default folder for received shares to "Shares"                     # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And auto-accept shares has been disabled                                                               # FeatureContext::autoAcceptSharesHasBeenDisabled()
    And using OCS API version "<ocs_api_version>"                                                          # FeatureContext::usingOcsApiVersion()
    And user "Alice" has been created with default attributes and without skeleton files                   # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt"        # FeatureContext::userHasUploadedAFileWithContentTo()
    And user "Brian" has been created with default attributes and without skeleton files                   # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    When user "Alice" shares file "textfile0.txt" with user "Brian" using the sharing API                  # FeatureContext::userSharesFileWithUserUsingTheSharingApi()
    And user "Brian" accepts share "/textfile0.txt" offered by user "Alice" using the sharing API          # FeatureContext::userReactsToShareOfferedBy()
    Then the HTTP status code should be "200"                                                              # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the content of file "/Shares/textfile0.txt" for user "Brian" should be "ownCloud test text file 0" # FeatureContext::contentOfFileForUserShouldBe()

    Examples:
      | ocs_api_version |
      | 1               |
        Sharing::userReactsToShareOfferedBy could not find share /textfile0.txt, offered by Alice to Brian
        Failed asserting that null is not null.
      | 2               |
        Sharing::userReactsToShareOfferedBy could not find share /textfile0.txt, offered by Alice to Brian
        Failed asserting that null is not null.

How is that related to the changes in this PR???

The PR needs a rebase anyway. Maybe that will help.

After rebasing and removing the two expected failures CI now passes. Thanks for the pointers!

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you want to adjust link in the changelog. But actually it works, so maybe not worth having to let CI run again.

Edit: I committed the changelog change - may as well get it fixed.

changelog/unreleased/update-web-1.0.1.md Outdated Show resolved Hide resolved
@phil-davis
Copy link
Contributor

Note: this also fixes QA isssue #1197

@kulmann
Copy link
Member Author

kulmann commented Jan 13, 2021

Maybe you want to adjust link in the changelog. But actually it works, so maybe not worth having to let CI run again.

Edit: I committed the changelog change - may as well get it fixed.

Thanks for taking care!

@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann kulmann merged commit 638b7a1 into master Jan 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-web-1.0.1 branch January 13, 2021 11:54
ownclouders pushed a commit that referenced this pull request Jan 13, 2021
Merge: 8462799 32b1597
Author: Benedikt Kulmann <[email protected]>
Date:   Wed Jan 13 12:54:19 2021 +0100

    Merge pull request #1191 from owncloud/update-web-1.0.1

    Update web to 1.0.1
@kulmann kulmann mentioned this pull request Jan 22, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate why some imageMediaViewer web UI tests fail when run in OCIS CI
3 participants