Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate cryptographically secure state token #1203

Merged
merged 1 commit into from
Jan 13, 2021
Merged

generate cryptographically secure state token #1203

merged 1 commit into from
Jan 13, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jan 12, 2021

Replaced Math.random with a cryptographically secure way to generate the oidc state token using the javascript crypto api.

https://developer.mozilla.org/en-US/docs/Web/API/Crypto/getRandomValues
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/random

@C0rby C0rby self-assigned this Jan 12, 2021
LukasHirt
LukasHirt approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@C0rby C0rby merged commit 133ecf4 into master Jan 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the secure-state branch January 13, 2021 13:52
ownclouders pushed a commit that referenced this pull request Jan 13, 2021
@C0rby
commit 133ecf4
8460538 
Merge: 1721b78 f230ea7
Author: David Christofas <[email protected]>
Date:   Wed Jan 13 14:52:54 2021 +0100

    Merge pull request #1203 from owncloud/secure-state

    generate cryptographically secure state token
@kulmann kulmann mentioned this pull request Jan 22, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refs refs refs approved these changes

@LukasHirt LukasHirt LukasHirt approved these changes

@IljaN IljaN Awaiting requested review from IljaN

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@C0rby @refs @LukasHirt