Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update roles cache to use sync.cache #1367

Merged
merged 1 commit into from
Jan 20, 2021
Merged

update roles cache to use sync.cache #1367

merged 1 commit into from
Jan 20, 2021

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Jan 20, 2021

this pr updates existing roles cache to use newly added sync cache

  • add tests for roles cache
  • add changelog
  • use strings in sync cache tests

@fschade
update roles cache to use sync.cache
fca41af 
add tests for roles cache
add changelog
use strings in sync cache tests
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fschade fschade requested a review from kulmann January 20, 2021 21:01
kulmann
kulmann reviewed Jan 20, 2021
View reviewed changes
ocis-pkg/roles/cache.go
ttl: ttl,
entries: map[string]entry{},
sc: sync.NewCache(capacity),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation/formatting is broken here 😅

kulmann
kulmann approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@fschade fschade marked this pull request as ready for review January 20, 2021 23:04
@fschade fschade merged commit 03c1416 into master Jan 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the roles-cache branch January 20, 2021 23:04
@kulmann kulmann mentioned this pull request Jan 22, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fschade @kulmann