Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reva to 1.5.1 #1372

Merged
merged 4 commits into from
Jan 22, 2021
Merged

Update reva to 1.5.1 #1372

merged 4 commits into from
Jan 22, 2021

Conversation

IljaN
Copy link
Member

@IljaN IljaN commented Jan 21, 2021 •
edited
Loading

@update-docs
Copy link

update-docs bot commented Jan 21, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@IljaN IljaN self-assigned this Jan 21, 2021
@IljaN IljaN force-pushed the update-reva-1.5.1 branch 2 times, most recently from f4b574f to 63d768d Compare January 21, 2021 14:20
IljaN added a commit to owncloud/web that referenced this pull request Jan 21, 2021
@IljaN
Adjust expected failures
7a2e235 
Less failures due to reva upgrade. See owncloud/ocis#1372
@IljaN IljaN mentioned this pull request Jan 21, 2021
Closed
phil-davis
phil-davis reviewed Jan 21, 2021
View reviewed changes
.drone.env Outdated
WEB_COMMITID=5878eeb7a9d7a1ef9259c1942d0ac8be57ecef02
WEB_BRANCH=master
WEB_COMMITID=7a2e2351b520e79a6203f083a7c7d257bdb3e7db
WEB_BRANCH=update-reva-1.5.1
Copy link
Contributor

@phil-davis phil-davis Jan 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is being done. Just set WEB_COMMITID to the latest commit in the master branch of owncloud/web, and adjust the expected-failures here in OCIS repo to remove whatever scenarios now pass.

After this OCIS PR is merged, there will then be a new OCIS_COMMITID at the head of owncloud/ocis master. A PR can be done in web to use that commit id "in the opposite direction"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR which updates reva removes expected failures which reside in ocis/web but are not yet merged to master.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See owncloud/web#4649

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IljaN if you change back to master branch of web and the latest web commit id, and rebase this PR to latest ocis master then this should pass. See #1382 where I tried that.

# The test runner source for UI tests
WEB_COMMITID=5945833ca594c16d33514da74b3d2eb64d3560fd
WEB_BRANCH=master

In PR owncloud/web#4652 I have already removed the webUITrashbinDelete/trashbinDelete.feature bug-demo scenario that is no longer relevant.

phil-davis
phil-davis reviewed Jan 22, 2021
View reviewed changes
.drone.env Outdated Show resolved Hide resolved
@phil-davis phil-davis mentioned this pull request Jan 22, 2021
Merged
9 tasks
@individual-it individual-it requested review from individual-it and removed request for individual-it January 22, 2021 06:41
@phil-davis phil-davis mentioned this pull request Jan 22, 2021
Closed
9 tasks
@phil-davis
Copy link
Contributor

I updated WEB_COMMITID to the latest. It was off-by-one. That will fix https://drone.owncloud.com/owncloud/ocis/2849/65/7

runsh: Total unexpected failed scenarios throughout the test run:
webUITrashbinDelete/trashbinDelete.feature:121

@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IljaN IljaN merged commit c18bae9 into master Jan 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-reva-1.5.1 branch January 22, 2021 11:36
@phil-davis
Copy link
Contributor

🎉

@IljaN
Copy link
Member Author

IljaN commented Jan 22, 2021

@phil-davis @individual-it Thanks you!

@kulmann kulmann mentioned this pull request Jan 22, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it individual-it approved these changes

Assignees

@IljaN IljaN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IljaN @phil-davis @individual-it