Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add volume to docker image #1375

Merged
merged 3 commits into from
Jan 21, 2021
Merged

add volume to docker image #1375

merged 3 commits into from
Jan 21, 2021

Conversation

wkloucek
Copy link
Contributor

Description

Adds a volume declaration to our docker images.

Related Issue

Motivation and Context

This makes it easier for the user to understand where data is stored.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested a review from xoxys January 21, 2021 13:51
xoxys
xoxys approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sonarcloud
Copy link

sonarcloud bot commented Jan 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 90cfa1e into master Jan 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the add_volume_docker_image branch January 21, 2021 15:50
@owncloud owncloud deleted a comment from update-docs bot Jan 21, 2021
ownclouders pushed a commit that referenced this pull request Jan 21, 2021
@phil-davis
commit 90cfa1e
cf62881 
Merge: afe098e 833d0e4
Author: Phil Davis <[email protected]>
Date:   Thu Jan 21 21:35:06 2021 +0545

    Merge pull request #1375 from owncloud/add_volume_docker_image

    add volume to docker image
@kulmann kulmann mentioned this pull request Jan 22, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoxys xoxys xoxys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wkloucek @xoxys @phil-davis