Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eos to makefile #172

Merged
merged 1 commit into from
Apr 16, 2020
Merged

add eos to makefile #172

merged 1 commit into from
Apr 16, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Mar 27, 2020

Seems like we need more instructions

in Makefile line 195 set host.docker.internal as LDAP_HOST
and then build ocis for linux like this: env GOOS=linux GOARCH=amd64 go build -o bin/ocis-linux ./cmd/ocis and copy it into the docker container
docker cp ./bin/ocis-linux eos-cli1:/usr/local/bin/ocis

@update-docs
Copy link

update-docs bot commented Mar 27, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic requested review from IljaN, micbar and refs March 27, 2020 12:05
docs/eos.md Outdated Show resolved Hide resolved
@butonic butonic force-pushed the ocis-on-eos branch 2 times, most recently from 0a126cd to 56d8479 Compare March 30, 2020 08:47
@butonic butonic self-assigned this Mar 30, 2020
@butonic butonic changed the title add eos to makefile [WIP] add eos to makefile Mar 31, 2020
@butonic
Copy link
Member Author

butonic commented Mar 31, 2020

we can merge this but it requires using a newer version of ocis-reva to actually work: owncloud/ocis-reva#127

Copy link
Member

@refs refs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@butonic
Copy link
Member Author

butonic commented Apr 2, 2020

I had to add explicit eos commands to preconfigure eos correctly, so now we depen on owncloud/ocis-reva#127

Makefile Outdated Show resolved Hide resolved
Copy link
Member

@refs refs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, wrong button, conflict strings must go :D

@butonic butonic force-pushed the ocis-on-eos branch 2 times, most recently from e84d675 to ae29af2 Compare April 9, 2020 15:56
@micbar
Copy link
Contributor

micbar commented Apr 15, 2020

@butonic please rebase, fixes the tests

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@micbar
Copy link
Contributor

micbar commented Apr 16, 2020

@butonic Fine for now.

@micbar micbar changed the title [WIP] add eos to makefile add eos to makefile Apr 16, 2020
@butonic butonic merged commit 2daae9e into owncloud:master Apr 16, 2020
@butonic butonic deleted the ocis-on-eos branch April 16, 2020 12:05
ownclouders pushed a commit that referenced this pull request Apr 16, 2020
Merge: f249c59 5ed1bc0
Author: Jörn Friedrich Dreyer <[email protected]>
Date:   Thu Apr 16 14:04:58 2020 +0200

    Merge pull request #172 from butonic/ocis-on-eos

    [WIP] add eos to makefile
@kulmann
Copy link
Member

kulmann commented Apr 16, 2020

For the sake of completeness, these are the things you need to do to get it running on macOS, @mbarz

  1. in Makefile line 195, where the LDAP_HOST is set, set host.docker.internal as LDAP_HOST
  2. run make eos-start. It will exit with an error, but the containers will be running. That's what's important.
  3. build ocis for linux like this: env GOOS=linux GOARCH=amd64 go build -o bin/ocis-linux ./cmd/ocis and copy it into the eos-cli1 docker container like this docker cp ./bin/ocis-linux eos-cli1:/usr/local/bin/ocis
  4. stop everything with make eos-stop
  5. since the linux binary has been copied in step 3, you can just start eos again with make eos-start.
  6. testing: https://localhost:9200/

Although eos will be running successfully then, it still fails to create any user home when running from macOS. This results in an access denied error on the user login page. I'm happy to help out debugging this, but since it's deep into eos, I lack the knowledge to do this efficiently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants