set missing env vars #392
Merged
set missing env vars #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
jnweiger
approved these changes
Jul 17, 2020
There was a problem hiding this comment.
Definitly correct in this docker-compose.yml.
@felixboehm please double-check, if needed elsewhere (compose-playground?) too!
kulmann
reviewed
Jul 17, 2020
|
fine if it works. I don’t understand these configs... we need to update in
|
butonic
force-pushed
the
add-missing-env-vars
branch
from
ee7884c
to
44fba8e
Compare
REVA_FRONTEND_URL and REVA_DATAGATEWAY_URL need to be set to the OCIS_DOMAIN so upload is not using localhost ;-) cc @jnweiger Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
add-missing-env-vars
branch
from
44fba8e
to
933a5be
Compare
refs
pushed a commit
that referenced
this pull request
Sep 18, 2020
Signed-off-by: Jörn Friedrich Dreyer <[email protected]> arm build failures unrelated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVA_FRONTEND_URL and REVA_DATAGATEWAY_URL need to be set to the OCIS_DOMAIN so upload is not using localhost ;-)
cc @jnweiger