External app config #473
Merged
External app config #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is nothing that would activate ocis-hello as an external app, so this can be just removed. Also it blocks the new default apps in ocis-phoenix.
IljaN
approved these changes
Aug 20, 2020
refs
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a new feature in ocis-phoenix, that creates a default set of external apps if there is no config.json for ocis-web provided. There was this line in ocis, that was blocking the default set of external apps from ocis-phoenix. As it was not doing what it comment promised anyway, we can safely remove it and let ocis-phoenix handle the defaults.