[full-ci] change: remove the settings ui #5463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
force-pushed
the
kill-the-settings-ui
branch
from
a81d0b8
to
ef4eef7
Compare
|
I had a very close look and couldn't find any more occurrences of the settings ui in config, docs, CI and of course the code itself. Please check carefully in review. |
|
Guess it deserves a changelog item (but perhaps adding one was scheduled for later :) )? |
kulmann
force-pushed
the
kill-the-settings-ui
branch
from
ef4eef7
to
a0cab68
Compare
Added one, thanks for the reminder :-) |
dschmidt
approved these changes
Feb 1, 2023
kulmann
force-pushed
the
kill-the-settings-ui
branch
from
a0cab68
to
bd9e6bc
Compare
ownCloud Web recently transitioned to Vue3. The settings ui is still written in Vue2. Since it's pretty much unused we won't take the efforts of upgrading it to Vue3.
kulmann
force-pushed
the
kill-the-settings-ui
branch
from
bd9e6bc
to
8c033e1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
micbar
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ownCloud Web recently transitioned to Vue3. The settings ui is still written in Vue2. Since it's pretty much unused we won't take the efforts of upgrading it to Vue3. The only setting ("Language") has been implemented in the
accountpage of ownCloud Web (reachable via user menu in the top right -> click on the username).Types of changes
Checklist: