Add username changing functionality. #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
ainmosni
force-pushed
the
ainmosni/issue/4988-ocis-Edit-username
branch
from
a7cbb82
to
295afd5
Compare
|
💥 Acceptance test wopiValidatorTests-ocis failed. Further test are cancelled... |
This is an incomplete implementation of username changing code. The things still needed to be finished: * The method that changes the member attribute has to be filled in. * The functionality needs to be tested. * Unit tests need to be added.
ainmosni
force-pushed
the
ainmosni/issue/4988-ocis-Edit-username
branch
from
295afd5
to
8fc6f6b
Compare
rhafer
requested changes
Feb 14, 2023
rhafer
approved these changes
Feb 15, 2023
|
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
bot
deleted the
ainmosni/issue/4988-ocis-Edit-username
branch
|
👍 excellent |
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for username changing.
Fixes #4988