[full-ci] Do not share versions #5531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
E2E tests failed: https://drone.owncloud.com/owncloud/ocis/21170/88/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/21170/tracing/file-alice-2023-4-5-09-54-57.zip |
micbar
force-pushed
the
dont-share-versions
branch
3 times, most recently
from
37c5236
to
56357be
Compare
micbar
force-pushed
the
dont-share-versions
branch
from
56357be
to
2cd6257
Compare
micbar
force-pushed
the
dont-share-versions
branch
from
d037587
to
ba77d05
Compare
4 tasks
saw-jan
reviewed
Apr 4, 2023
saw-jan
reviewed
Apr 4, 2023
ScharfViktor
reviewed
Apr 4, 2023
|
@ScharfViktor Ok, you can take over that PR. Only adapting the acceptance tests is needed. |
|
let me do a rebase. |
|
I should probably fix e2e and bring new webBump to PR |
3 tasks
|
I think I'm done. I bump webCommit and CI should be green. @micbar could you check if the |
saw-jan
reviewed
Apr 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
saw-jan
approved these changes
Apr 6, 2023
ownclouders
pushed a commit
that referenced
this pull request
Apr 6, 2023
* change test expectations * bump reva version * add changelog * fix test * php style fix * bump webCommit. fixt contarct tests * change webBranch * change webBranch * new web commit * fix flaky draw.io file * fix after review --------- Co-authored-by: Viktor Scharf <[email protected]>
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change: Do not share versions
We changed the default behavior of shares: Share receivers have no access to versions. People in spaces with the "Editor" or "Manager" role can still see versions and work with them.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: