Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph: Add accountEnabled flag to ldap backend. #5588

Merged
merged 2 commits into from
Feb 17, 2023
Merged

graph: Add accountEnabled flag to ldap backend. #5588

merged 2 commits into from
Feb 17, 2023

Conversation

Excds
Copy link
Contributor

@Excds Excds commented Feb 16, 2023

Description

Add boolean accountEnabled property to users in the ldap backend.

Related Issue

How Has This Been Tested?

Tested manually with curl and added unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@Excds Excds added the Status:Needs-Review Needs review from a maintainer label Feb 16, 2023
@Excds Excds requested review from rhafer and butonic February 16, 2023 11:54
@Excds Excds self-assigned this Feb 16, 2023
@update-docs
Copy link

update-docs bot commented Feb 16, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

💥 Acceptance test wopiValidatorTests-ocis failed. Further test are cancelled...

rhafer
rhafer previously requested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@rhafer rhafer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the flag is not returned yet when listing users.

curl -k  -u admin:admin 'https://localhost:9200/graph/v1.0/use/058bff95-6708-4fe5-91e4-9ea3d377588b`

works while

curl -k  -u admin:admin 'https://localhost:9200/graph/v1.0/users'

doesn't

@mmattel mmattel mentioned this pull request Feb 16, 2023
Closed
@Excds
Copy link
Contributor Author

Excds commented Feb 17, 2023

Seems that the flag is not returned yet when listing users.

curl -k  -u admin:admin 'https://localhost:9200/graph/v1.0/use/058bff95-6708-4fe5-91e4-9ea3d377588b`

works while

curl -k  -u admin:admin 'https://localhost:9200/graph/v1.0/users'

doesn't

Added the missed flag to listing user. Note that it can still be nil, and therefore not returned as it will be skipped in the libregraph struct.

@Excds Excds closed this Feb 17, 2023
@Excds
Copy link
Contributor Author

Excds commented Feb 17, 2023

Facepalm. "comment and close" closes the PR, not the comment thread.

@Excds Excds reopened this Feb 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

68.2% 68.2% Coverage
0.0% 0.0% Duplication

@butonic butonic merged commit fcf5783 into master Feb 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the excds/feature/5553_Add_accountEnabled_flag_to_ldap branch February 17, 2023 12:48
ownclouders pushed a commit that referenced this pull request Feb 17, 2023
@Excds
commit fcf5783
9bd74dc 
Author: Daniel Swärd <[email protected]>
Date:   Fri Feb 17 13:48:12 2023 +0100

    graph: Add accountEnabled flag to ldap backend. (#5588)

    * graph: Add accountEnabled flag to ldap backend.

    * Add missing accountEnabled attribute to user listing.
ownclouders pushed a commit that referenced this pull request Feb 17, 2023
@Excds
commit fcf5783
68ef38d 
Author: Daniel Swärd <[email protected]>
Date:   Fri Feb 17 13:48:12 2023 +0100

    graph: Add accountEnabled flag to ldap backend. (#5588)

    * graph: Add accountEnabled flag to ldap backend.

    * Add missing accountEnabled attribute to user listing.
@rhafer rhafer mentioned this pull request Apr 5, 2023
Closed
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@rhafer rhafer rhafer left review comments

Assignees

@Excds Excds

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

graph: Add accountEnabled property to /users
4 participants
@Excds @ownclouders @rhafer @butonic