Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add constraints to permissions listing #5594

Merged
merged 1 commit into from
Feb 17, 2023
Merged

add constraints to permissions listing #5594

merged 1 commit into from
Feb 17, 2023

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Feb 17, 2023

Description

Quickfix: adds constraints to the listed permission names.

Will have a follow up PR to clean up the broken naming pattern.

Unblocks @JammingBen

possible values for the constraint

value
unknown
own
shared
all

Example

curl -L -k -X POST 'https://localhost:9200/api/v0/settings/permissions-list' \
-H 'Content-Type: application/json' \
--data-raw '{
    "account_uuid": "4c510ada-c86b-4815-8820-42cdf82c3d51"
}'
{
    "permissions": [
        "list-all-spaces.all",
        "language-readwrite.own",
        "self-management.own",
        "create-space.own",
        "Drive.ReadWrite.all",
        "Drive.ReadWriteEnabled.all",
        "set-space-quota.all",
        "create-space.all"
    ]
}

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me 👍 Can't review the technical side though.

@butonic butonic merged commit 794f6cd into master Feb 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-constraints branch February 17, 2023 12:45
ownclouders pushed a commit that referenced this pull request Feb 17, 2023
Author: Michael Barz <[email protected]>
Date:   Fri Feb 17 13:45:47 2023 +0100

    add constraints to permissions listing (#5594)
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants