thumbnails: Add portrait resolutions to default config #5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Signed-off-by: jkoberg <[email protected]>
kobergj
approved these changes
Feb 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds corresponding portrait-orientation resolutions for each existing landscape-orientation resolution to the thumbnailer service's default config.
Related Issue
This improves, but does not actually fix, the following bug (affecting web):
Motivation and Context
Cropping portrait-orientation photos to landscape greatly reduces the usefulness of the resulting thumbnails (see the screenshots section below.)
How Has This Been Tested?
I added these three portrait-orientation resolutions to the config on my own server, and it improved the behavior by allowing a portrait-orientation photo to have a portrait-orientation preview. (The behavior is still not ideal because the preview should not be cropped at all, but this at least allows me to see most of the image in the preview, instead of a small fraction of it.)
Screenshots (if appropriate):
I have been uploading scanned documents to my OCIS server, some of which are in image format. Below is what a document looked like with the current default config (left), and what it looks like after adding the portrait orientations (right):
Much more of the image is now visible in the web view.
Although this isn't a proper fix for the web view bug, it seems to make sense that anyone with a portrait-orientation photo and using it in a cropped/thumbnailed context would prefer to have more of their photo appear in the thumbnail. Adding the portrait orientations to the default config was suggested by an ownCloud developer here.
Types of changes
Checklist: