Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] chore: bump test-middleware to v1.8.5 #5714

Merged
merged 3 commits into from
Mar 3, 2023
Merged

[full-ci] chore: bump test-middleware to v1.8.5 #5714

merged 3 commits into from
Mar 3, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Mar 2, 2023 •
edited
Loading

Bumps the owncloud-test-middleware to v1.8.4 which adds a retry for async webdav downloads webdav downloads after async uploads.

Edit: now actually bumping to v1.8.5, because v1.8.4 only made one single retry per file. Needs the option for multiple retries.

@kulmann kulmann requested a review from kobergj March 2, 2023 10:44
@owncloud owncloud deleted a comment from update-docs bot Mar 2, 2023
@micbar
Copy link
Contributor

micbar commented Mar 2, 2023

hmm, upload tests are still failing. Did we miss anything?

@kulmann kulmann changed the title [full-ci] chore: bump test-middleware to v1.8.4 [full-ci] chore: bump test-middleware to v1.8.5 Mar 2, 2023
@individual-it
Copy link
Member

strangely it never waits for 1 or 2 retries, ether it passes immediately or never

@kulmann
Copy link
Member Author

kulmann commented Mar 3, 2023

strangely it never waits for 1 or 2 retries, ether it passes immediately or never

Yep, seems to be a different issue. @kobergj is already looking into it.

Still good to have the retries on 425 now though. 😅

@micbar how do you feel about force merging this one? The test failures are unrelated to the PR and it already might help to reduce flakiness.

@kobergj kobergj force-pushed the bump-test-middleware-1.8.4 branch 3 times, most recently from 19832a0 to 051a11e Compare March 3, 2023 13:19
wkloucek
wkloucek requested changes Mar 3, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@kobergj kobergj marked this pull request as draft March 3, 2023 13:32
@wkloucek wkloucek self-requested a review March 3, 2023 13:45
@kobergj
bump reva
32933ce 
Signed-off-by: jkoberg <[email protected]>
@kobergj kobergj force-pushed the bump-test-middleware-1.8.4 branch from 051a11e to 32933ce Compare March 3, 2023 14:17
@kobergj kobergj marked this pull request as ready for review March 3, 2023 14:17
@kobergj
Copy link
Collaborator

kobergj commented Mar 3, 2023 •
edited
Loading

Found out what the issue was. It has been our old friend, the cache. (Who else could it be.) I adjusted caching in reva. Pipeline went green twice already. Should be ready to go now 🤞

@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@micbar
Copy link
Contributor

micbar commented Mar 3, 2023

Docker arm32 is not available. Known issue. Merging.

@micbar micbar merged commit 1599289 into master Mar 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the bump-test-middleware-1.8.4 branch March 3, 2023 15:08
ownclouders pushed a commit that referenced this pull request Mar 3, 2023
@micbar
commit 1599289
a28ee85 
Merge: 2242254 32933ce
Author: Michael Barz <[email protected]>
Date:   Fri Mar 3 16:08:26 2023 +0100

    Merge pull request #5714 from owncloud/bump-test-middleware-1.8.4

    [full-ci] chore: bump test-middleware to v1.8.5
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@phil-davis phil-davis phil-davis approved these changes

@micbar micbar Awaiting requested review from micbar micbar is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@wkloucek wkloucek Awaiting requested review from wkloucek wkloucek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kulmann @micbar @individual-it @kobergj @phil-davis @wkloucek