Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add common part, make the logic theme name agnostic #5735

Merged
merged 1 commit into from
Mar 6, 2023
Merged

add common part, make the logic theme name agnostic #5735

merged 1 commit into from
Mar 6, 2023

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Mar 6, 2023 •
edited
Loading

Description

  • Make common logo key also replacable
  • Make the logic theme name agnostic

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar requested a review from kulmann as a code owner March 6, 2023 09:46
@micbar micbar requested a review from C0rby March 6, 2023 09:47
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit 8d937a3 into master Mar 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the branding-improvements branch March 6, 2023 11:03
ownclouders pushed a commit that referenced this pull request Mar 6, 2023
@micbar
commit 8d937a3
5319563 
Merge: b517a6c e05e3b9
Author: Michael Barz <[email protected]>
Date:   Mon Mar 6 12:03:55 2023 +0100

    Merge pull request #5735 from owncloud/branding-improvements

    add common part, make the logic theme name agnostic
ownclouders pushed a commit that referenced this pull request Mar 6, 2023
@micbar
commit 8d937a3
c8f05e2 
Merge: b517a6c e05e3b9
Author: Michael Barz <[email protected]>
Date:   Mon Mar 6 12:03:55 2023 +0100

    Merge pull request #5735 from owncloud/branding-improvements

    add common part, make the logic theme name agnostic
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@kulmann kulmann Awaiting requested review from kulmann kulmann is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@micbar @C0rby