Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more logging to antivirus #5973

Merged
merged 2 commits into from
Apr 5, 2023
Merged

add more logging to antivirus #5973

merged 2 commits into from
Apr 5, 2023

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Mar 30, 2023 •
edited
Loading

Description

Enhancement: Add more logging to av service

We need more debug logging sometimes to understand the state of a virus scan.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 30, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Mar 30, 2023 •
edited
Loading

E2E tests failed: https://drone.owncloud.com/owncloud/ocis/21100/68/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/21100/tracing/folder-alice-2023-4-4-07-35-36.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/21100/tracing/folder-brian-2023-4-4-07-35-50.zip

@micbar micbar marked this pull request as ready for review April 4, 2023 07:20
kobergj
kobergj requested changes Apr 4, 2023
View reviewed changes
services/antivirus/pkg/service/service.go Outdated Show resolved Hide resolved
services/antivirus/pkg/service/service.go Outdated Show resolved Hide resolved
services/antivirus/pkg/service/service.go Outdated Show resolved Hide resolved
@micbar micbar requested review from kobergj and mmattel April 4, 2023 09:10
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit 802cf4d into master Apr 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the av-logging branch April 5, 2023 07:29
ownclouders pushed a commit that referenced this pull request Apr 5, 2023
@micbar
Merge pull request #5973 from owncloud/av-logging
e9cc4fa 
add more logging to antivirus
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

@mmattel mmattel Awaiting requested review from mmattel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@micbar @ownclouders @mmattel @kobergj