trace proxie middlewares #6313
Merged
trace proxie middlewares #6313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
force-pushed
the
trace-proxie-middlewares
branch
5 times, most recently
from
67e8127
to
e5bb7f1
Compare
dragonchaser
approved these changes
May 26, 2023
|
E2E tests failed: https://drone.owncloud.com/owncloud/ocis/22761/69/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/22761/tracing/public-link-for-space-alice-2023-5-26-09-45-38.zip |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Co-authored-by: Christian Richter <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
trace-proxie-middlewares
branch
from
bc9527e
to
b9fb4c3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
May 27, 2023
* trace proxie middlewares Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * Update ocis-pkg/service/grpc/client.go Co-authored-by: Christian Richter <[email protected]> * default tls is off Signed-off-by: Jörn Friedrich Dreyer <[email protected]> --------- Signed-off-by: Jörn Friedrich Dreyer <[email protected]> Co-authored-by: Christian Richter <[email protected]>
86 tasks
fschade
pushed a commit
that referenced
this pull request
Jul 10, 2023
* trace proxie middlewares Signed-off-by: Jörn Friedrich Dreyer <[email protected]> * Update ocis-pkg/service/grpc/client.go Co-authored-by: Christian Richter <[email protected]> * default tls is off Signed-off-by: Jörn Friedrich Dreyer <[email protected]> --------- Signed-off-by: Jörn Friedrich Dreyer <[email protected]> Co-authored-by: Christian Richter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved trace initialization to an early middleware to also trace requests made by other proxy middlewares.
before:
after:
so we basically have not seen 60ms of all requests ... 😞
when using a proper ldap server and not the built in GetUserByClaim also is way faster:
might be related to #5765 ... because we don't care about the built in LDAP ... 😞