Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests #issue-4265 #6398

Merged
merged 1 commit into from
May 31, 2023
Merged

fix tests #issue-4265 #6398

merged 1 commit into from
May 31, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented May 26, 2023

Description

Fixed the empty exact list in response to getting sharees while searching
cs3org/reva#3877

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: local
  • test 1: API tests
  • test 2: manually. Created 3 users "einstein", "Einstein1" and "Einstein_one". Search the sharee by "einstein"
    Got the response
{
    "ocs": {
        "meta": {
            "status": "ok",
            "statuscode": 200,
            "message": "OK"
        },
        "data": {
            "exact": {
                "users": [
                    {
                        "label": "Albert Einstein",
                        "value": {
                            "shareType": 0,
                            "shareWith": "einstein",
                            "shareWithAdditionalInfo": "[email protected]",
                            "userType": 0
                        }
                    }
                ],
                "groups": [],
                "remotes": []
            },
            "users": [
                {
                    "label": "Einstein1",
                    "value": {
                        "shareType": 0,
                        "shareWith": "Einstein1",
                        "shareWithAdditionalInfo": "[email protected]",
                        "userType": 0
                    }
                },
                {
                    "label": "Einstein_one",
                    "value": {
                        "shareType": 0,
                        "shareWith": "Einstein_one",
                        "shareWithAdditionalInfo": "[email protected]",
                        "userType": 0
                    }
                }
            ],
            "groups": [],
            "remotes": []
        }
    }
}

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented May 26, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented May 26, 2023

💥 Acceptance test Core-API-Tests-ocis-storage-5 failed. Further test are cancelled...

@2403905 2403905 force-pushed the issue-4265 branch 5 times, most recently from 953a34d to 01bc14b Compare May 31, 2023 13:43
@2403905 2403905 marked this pull request as ready for review May 31, 2023 13:43
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@2403905 2403905 merged commit 09c95d3 into owncloud:master May 31, 2023
ownclouders pushed a commit that referenced this pull request May 31, 2023
Fixed the empty exact list in response to getting sharees while searching #issue-4265
@micbar micbar mentioned this pull request Jun 6, 2023
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ocs sharing api always returns an empty exact list while searching for a sharee
3 participants