Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to prevent the email notification X-Site scripting #6429

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix to prevent the email notification X-Site scripting #6429

merged 1 commit into from
Jun 2, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Jun 1, 2023 •
edited
Loading

Description

To prevent the email notification X-Site scripting the untrusted data are escaped in a email HTML body.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: local, unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@2403905 2403905 force-pushed the issue-6411 branch 2 times, most recently from 5a09c6c to e6ec327 Compare June 1, 2023 15:58
@2403905 2403905 requested a review from kobergj June 1, 2023 16:47
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

55.6% 55.6% Coverage
0.0% 0.0% Duplication

@2403905 2403905 merged commit ecc56ce into owncloud:master Jun 2, 2023
ownclouders pushed a commit that referenced this pull request Jun 2, 2023
@2403905
Merge pull request #6429 from 2403905/issue-6411
1052af2 
Fix to prevent the email notification X-Site scripting
@micbar micbar mentioned this pull request Jun 6, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use safehtml/template instead html/template
2 participants
@2403905 @kobergj