Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] allow to disable previews in webdav & web #6577

Merged

Conversation

dragonchaser
Copy link
Member

@dragonchaser dragonchaser commented Jun 21, 2023

We added an env var OCIS_DISABLE_PREVIEWS to disable the thumbnails for web & webdav via a global setting.
For each service this behaviour can be disabled using the local env vars WEB_OPTION_DISABLE_PREVIEWS (old)
and WEBDAV_OPTION_DISABLE_PREVIEWS (new).

refs #192

@update-docs
Copy link

update-docs bot commented Jun 21, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dragonchaser dragonchaser force-pushed the issue-192-disable-thumbnailer branch from 7f250d0 to b3fd53d Compare June 22, 2023 13:44
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser dragonchaser force-pushed the issue-192-disable-thumbnailer branch from 5f2e368 to a63931a Compare June 22, 2023 13:47
@dragonchaser dragonchaser changed the title disable thumbnail service when web prevents previews [full-ci] disable thumbnail service when web prevents previews Jun 22, 2023
@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-7 failed. Further test are cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-3 failed. Further test are cancelled...

@dragonchaser dragonchaser marked this pull request as ready for review June 22, 2023 14:06
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised by thise change. The web option only prevents thumbnails in order to give the possibility to speed up the file list rendering. It does not block previews in the right sidebar details panel. And most importantly the "preview" app which is responsible for rendering media files in a single folder also uses the thumbnail service (using higher resolutions) to render the images relatively big and with high resolution.

Disabling the thumbnail service alltogether seems a little too much for me. Also, I don't share the expected behaviour in the ticket.

Signed-off-by: Christian Richter <[email protected]>
@dragonchaser dragonchaser changed the title [full-ci] disable thumbnail service when web prevents previews [full-ci] allow to disable previews in webdav & web Jun 23, 2023
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just some description suggestions. But @mmattel is more qualified to judge that 😉

services/webdav/pkg/config/config.go Outdated Show resolved Hide resolved
services/web/pkg/config/options.go Outdated Show resolved Hide resolved
Signed-off-by: Christian Richter <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dragonchaser dragonchaser merged commit b06f7ec into owncloud:master Jun 27, 2023
1 check passed
@dragonchaser dragonchaser deleted the issue-192-disable-thumbnailer branch June 27, 2023 12:01
ownclouders pushed a commit that referenced this pull request Jun 27, 2023
[full-ci] allow to disable previews in webdav & web
@micbar micbar mentioned this pull request Jul 24, 2023
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants