Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IDs to graph access logs #6593

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Add IDs to graph access logs #6593

merged 2 commits into from
Jun 23, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jun 22, 2023

Fixes #6576

@micbar
Copy link
Contributor

micbar commented Jun 22, 2023

I made some comments. I think these should apply to the other occurrances too. We should log what has changed.

@kobergj kobergj requested a review from micbar June 22, 2023 12:07
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
48.0% 48.0% Duplication

@kobergj kobergj marked this pull request as ready for review June 22, 2023 13:34
@kobergj kobergj mentioned this pull request Jun 23, 2023
Closed
micbar
micbar approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us merge and see if that is sufficient to get a speaking access log

@kobergj kobergj merged commit 9fc3714 into owncloud:master Jun 23, 2023
2 checks passed
@kobergj kobergj deleted the AddIDsToGraphResourceLogging branch June 23, 2023 14:12
ownclouders pushed a commit that referenced this pull request Jun 23, 2023
@kobergj
Merge pull request #6593 from kobergj/AddIDsToGraphResourceLogging
d632e37 
Add IDs to graph access logs
@micbar micbar mentioned this pull request Jul 24, 2023
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graph API education resources logging
2 participants
@kobergj @micbar