Fix OIDC role assigner #6605
Merged
Fix OIDC role assigner #6605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkoberg <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
micbar
approved these changes
Jun 22, 2023
rhafer
reviewed
Jun 23, 2023
| err := errors.New("too many roles assigned") | ||
| logger.Error().Err(err).Msg("The user has too many roles assigned") | ||
| return nil, err | ||
| logger.Error().Str("userID", user.GetId().GetOpaqueId()).Int("numRoles", len(assignedRoles)).Msg("The user has too many roles assigned") |
There was a problem hiding this comment.
@kobergj I know I am a bit late to the party, but I fear this is not enough. We need to make sure that the assignment is re-written when len(assignedRoles) > 1. Otherwise other code reading the assigments might get confused.
It should be enough to turn the if len(assignedRoles) == 0 || (assignedRoles[0] != roleIDFromClaim) on line 96 into if len(assignedRoles) != 1 || (assignedRoles[0] != roleIDFromClaim) for that to happen.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/owncloud/enterprise/issues/5805