Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] enhancement: add search result content preview and term highlighting. #6634

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Jun 27, 2023

Description

The search result REPORT response now contains a content preview which highlights the search term.
The feature is only available if content extraction (e.g. apache tika) is configured.

Questions

  • not sure if oc:preview is the best naming, ideas?
  • what if no preview is available (no content extraction available), remove oc:preview node or keep it and have it empty? cc.: @janackermann
    • discussed with @tbsbdr, we keep it as empty node
  • what if the user searches for name only, no content preview term highlighting is available.

Related Issue

Motivation and Context

--

How Has This Been Tested?

--

Screenshots (if appropriate):

Bildschirm­foto 2023-06-27 um 09 20 33

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@fschade fschade changed the title enhancement: add search result content preview and term highlighting. [full-ci] enhancement: add search result content preview and term highlighting. Jun 27, 2023
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fschade fschade marked this pull request as ready for review June 27, 2023 12:46
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.1% 94.1% Coverage
0.0% 0.0% Duplication

@fschade fschade merged commit a26aea7 into owncloud:master Jun 27, 2023
1 check passed
ownclouders pushed a commit that referenced this pull request Jun 27, 2023
…hlighting. (#6634)

* enhancement: add search result content preview and term highlighting.

* chore: fix changelog

* noop

* enhancement: provide search highlight tests
fschade added a commit that referenced this pull request Jul 10, 2023
…hlighting. (#6634)

* enhancement: add search result content preview and term highlighting.

* chore: fix changelog

* noop

* enhancement: provide search highlight tests
@micbar micbar mentioned this pull request Jul 24, 2023
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ocis] Search: Provide search highlight
4 participants