Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Fix the default document language for OnlyOffice #6878

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Jul 24, 2023

Description

Fix the default document language for OnlyOffice

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: The local docker stack wopi setup:
  • checkout to the issue branch and build the dev image make -C ocis dev-docker
  • go to deployments/examples/ocis_wop
  • run export OCIS_DOCKER_TAG=dev and docker-compose up -d
  • test case 1: Change the language to desirable in the Account settings (Galego is not supported). Create the new Microsoft Word document.
    Expected result: The UI and document language match to ocis language.

Screenshots (if appropriate):

Screenshot 2023-07-24 at 18 52 10

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@2403905 2403905 requested a review from micbar July 25, 2023 07:34
@2403905 2403905 changed the title Fix the default document language for OnlyOffice [full-ci] Fix the default document language for OnlyOffice Jul 25, 2023
@2403905 2403905 marked this pull request as ready for review July 25, 2023 13:14
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor
Copy link
Contributor

tested. works fine to me 👍
Screenshot 2023-07-26 at 11 07 25

@2403905 2403905 merged commit 436eae2 into owncloud:master Jul 26, 2023
2 checks passed
ownclouders pushed a commit that referenced this pull request Jul 26, 2023
[full-ci] Fix the default document language for OnlyOffice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants