Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Evaluate policy resource information on single file shares #6888

Merged
merged 5 commits into from
Jul 31, 2023

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Jul 25, 2023

Description

The policy environment for single file shares now also includes information about the resource.
As a result, it is now possible to set up and check rules for them.

Related Issue

  • Fixes - private repo issue

Motivation and Context

be able to obtain information on single file shares from rego.

How Has This Been Tested?

  • see unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@fschade fschade force-pushed the singe-file-share-policy-info branch from 54003f8 to 194c595 Compare July 26, 2023 11:16
@fschade fschade requested a review from kobergj July 27, 2023 08:19
@fschade fschade marked this pull request as ready for review July 27, 2023 08:19
@fschade fschade force-pushed the singe-file-share-policy-info branch from 15c5707 to 7e2b2f0 Compare July 27, 2023 08:24
services/policies/pkg/engine/opa/engine.go Outdated Show resolved Hide resolved
services/proxy/pkg/middleware/policies_test.go Outdated Show resolved Hide resolved
@fschade fschade requested a review from kobergj July 28, 2023 11:25
@fschade fschade force-pushed the singe-file-share-policy-info branch from 16e9431 to ea4742c Compare July 31, 2023 07:32
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

42.9% 42.9% Coverage
0.0% 0.0% Duplication

@fschade fschade merged commit 90ba75e into owncloud:master Jul 31, 2023
3 checks passed
ownclouders pushed a commit that referenced this pull request Jul 31, 2023
…es (#6888)

* enhancement: Evaluate policy resource information on single file shares

* enhancement: switch to resource name evaluation for example rego put rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants