fix: use error detail as message instead of whole error object

[saw-jan]

Description

Whenever the file preview requests fail with 400 Bad Request, full error object was returned as error message for the webdav response. For example (try to get folder preview);

curl "https://localhost:9200/remote.php/dav/files/admin/folder?x=32&y=32&forceIcon=0&preview=1" \
-uadmin:admin -vk

Current,

...
< HTTP/1.1 400 Bad Request
...

<?xml version="1.0" encoding="UTF-8"?>
<d:error
	xmlns:d="DAV"
	xmlns:s="http://sabredav.org/ns">
	<s:exception>Sabre\DAV\Exception\BadRequest</s:exception>
	<s:message>{"id":"com.owncloud.api.thumbnails","code":400,"detail":"Unsupported file type","status":"Bad Request"}</s:message>
</d:error>

This PR fixes the redundancy in the error message and only return detail from the error object.

With PR,

...
	<s:exception>Sabre\DAV\Exception\BadRequest</s:exception>
	<s:message>Unsupported file type</s:message>
...

Related Issue

• Fixes different error message detail for previews of folder #2064

Motivation and Context

return proper error message in the response

How Has This Been Tested?

• local
• CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[saw-jan]

@kobergj @2403905 Here is another one

[saw-jan]

Passing test: https://drone.owncloud.com/owncloud/ocis/24860/67/6

[kobergj]

LGTM 👍

[saw-jan]

LGTM 👍

Thanks 😃
I will push changelog and remove passing test from expected failure list

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
75.0% Duplication