Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cache header for web and theme assets #6914

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Fix cache header for web and theme assets #6914

merged 1 commit into from
Jul 28, 2023

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jul 28, 2023

Description

Bugfix: Let clients cache web and theme assets

We needed to remove "must-revalidate" from the cache-control header to allow clients to cache the web and theme assets.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar requested a review from kulmann as a code owner July 28, 2023 09:04
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit 1a8516c into master Jul 28, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-static-cache branch July 28, 2023 13:22
ownclouders pushed a commit that referenced this pull request Jul 28, 2023
@micbar
Merge pull request #6914 from owncloud/fix-static-cache
040eb63 
Fix cache header for web and theme assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@kulmann kulmann Awaiting requested review from kulmann kulmann is a code owner

@fmoc fmoc Awaiting requested review from fmoc

@dschmidt dschmidt Awaiting requested review from dschmidt

@JammingBen JammingBen Awaiting requested review from JammingBen

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow desktop client to cache resources
2 participants
@micbar @kobergj