Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint token with uid and gid #737

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Conversation

butonic
Copy link
Member

@butonic butonic commented Oct 22, 2020

The eos driver expects the uid and gid from the opaque map of a user. While the proxy does mint tokens correctly, the accounts service wasn't.

@butonic butonic self-assigned this Oct 22, 2020
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann
Copy link
Member

kulmann commented Oct 22, 2020

I restarted the build. Phoenix pipeline 2 was failing, which is a random failure (will be fixed with next phoenix update).

@butonic butonic force-pushed the mint-token-with-uid branch 2 times, most recently from 058bf1c to e318540 Compare October 23, 2020 06:19
@kulmann
Copy link
Member

kulmann commented Oct 23, 2020

I will add another commit to this, which also mints the uid and gid number of the service user when talking to the index.

@kulmann
Copy link
Member

kulmann commented Oct 23, 2020

Now added a commit for the service user auth on indices.

@butonic butonic force-pushed the mint-token-with-uid branch 3 times, most recently from f55ce94 to be9f4ca Compare October 23, 2020 12:02
butonic and others added 2 commits October 23, 2020 14:05
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Refactored some duplicated code into a helper.
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 1df00ea into owncloud:master Oct 23, 2020
@butonic butonic deleted the mint-token-with-uid branch June 8, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants