Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement sharing roles #7524

Merged
merged 1 commit into from
Oct 24, 2023
Merged

implement sharing roles #7524

merged 1 commit into from
Oct 24, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Oct 18, 2023

Description

Two endpoints that map roles have been added
https://owncloud.dev/libre-graph-api/#/roleManagement

Redundant roles RoleUnknown, RoleLegacy, RoleDenied, RoleNone that have no permissions have been skipped.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: local
  • test case 1: call the API

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@rhafer
Copy link
Contributor

rhafer commented Oct 19, 2023

@2403905 Would you mind adding a somewhat more descriptive test to the commit messages (and PR description) about what this actually does? That would be helpful for any possible reviwers. "implement sharing roles" is pretty sparse without any further context 😄

@2403905 2403905 marked this pull request as ready for review October 19, 2023 07:46
@2403905 2403905 requested a review from rhafer October 19, 2023 11:20
@2403905 2403905 force-pushed the issue-7418 branch 2 times, most recently from 75366c6 to 98671af Compare October 19, 2023 17:50
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

9.4% 9.4% Coverage
0.0% 0.0% Duplication

@2403905 2403905 merged commit d185b71 into owncloud:master Oct 24, 2023
2 checks passed
ownclouders pushed a commit that referenced this pull request Oct 24, 2023
Co-authored-by: Roman Perekhod <[email protected]>
nabim777 pushed a commit that referenced this pull request Oct 26, 2023
Co-authored-by: Roman Perekhod <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants