-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add graph beta sharedWithMe API #7633
Conversation
bf2d0ef
to
ad146ff
Compare
CI will fail for the moment, its expected, .... somehow my locally generated swagger api uses UPPERCase letters for |
i could need a second pair of eyes (web :)) to see what else is needed, cc.: @kulmann |
0c80c9e
to
e44bc2a
Compare
@fschade Yeah, that's a changed default in the go-generator. since version 6 (IIRC) You need to call it with |
😮 THX |
7f8bc15
to
120fbba
Compare
e61c482
to
634bc29
Compare
634bc29
to
95998e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me in general. Commented on just a few minor things.
One question though. owncloud/libre-graph-api#112 talked about the permissions
property on sharedWithMe
. You code currently doesn't populate that. Is that no longer needed? If yes, how does a user figure out its own permissions (and expiry) on a share?
d411d4f
to
7b63628
Compare
i want to wait for the Role <-> Permissions Conversion, once these are settled i planned to add them in a separate pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me. Let's to the rest in followup PRs.
(btw, I'd prefer if stuff like the libregraph-api bump would be in separate commits, IMO that simplifies review a bit. Just as a side-note for the future)
7b63628
to
588be1b
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
Add graph beta api implementation for the sharedWithMe endpoint.
The implementation is a logical replication of the existing OCS API.
Related Issue
Motivation and Context
part of the OCS api to graph api ADR
How Has This Been Tested?
Types of changes
Checklist:
MS Graph (oneDrive) share livecycle
Process
User A
has 2 resourcesTest (folder)
Card.pdf (file)
User A
sharesTest (folder)
,Card.pdf (file)
TOUser B
Card.pdf (file)
TOUser C
User B
sharesTest (folder)
TOUser C
Result
/v1.0/me/drive/root/children
forUser A
Result
/v1.0/me/drive/sharedWithMe
forUser B
Result
/v1.0/me/drive/sharedWithMe
forUser C