Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configs for the Web embed mode #7670

Merged
merged 3 commits into from
Nov 7, 2023
Merged

feat: add configs for the Web embed mode #7670

merged 3 commits into from
Nov 7, 2023

Conversation

JammingBen
Copy link
Contributor

Description

Adds 2 new configs for the Web embed mode:

  • mode Defines the mode in which Web will be running.
  • embedTarget Defines how Web is being integrated when running in embed mode.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@JammingBen JammingBen self-assigned this Nov 7, 2023
@mmattel
Copy link
Contributor

mmattel commented Nov 7, 2023

@JammingBen as discussed, I added a small section in the web's readme pls a reference in the envvars to look for the docs.

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel mmattel merged commit 5a17649 into master Nov 7, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the web-embed-configs branch November 7, 2023 11:01
ownclouders pushed a commit that referenced this pull request Nov 7, 2023
feat: add configs for the Web embed mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants