Ocis 5455 language setting #7720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
reviewed
Nov 13, 2023
dragonchaser
force-pushed
the
ocis-5455-language-setting
branch
from
12922b4
to
3cc2a19
Compare
|
Please rebase to master as there were changes to |
AlexAndBear
previously requested changes
Nov 13, 2023
dragonchaser
force-pushed
the
ocis-5455-language-setting
branch
4 times, most recently
from
03eeb54
to
f58c435
Compare
fschade
approved these changes
Nov 14, 2023
10 tasks
|
We have found a massive bug, the language is not correctly stored and retrieved, working on it |
micbar
reviewed
Nov 15, 2023
|
e2e test error. whether your changes could have affected the GET user https://drone.owncloud.com/owncloud/ocis/28760/40/12 
|
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]> Co-authored-by: Julian Koberg <[email protected]> Co-authored-by: Michael Barz <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
… language Co-authored-by: Florian Schade <[email protected]> Signed-of-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]> Co-authored-by: Julian Koberg <[email protected]> Co-authored-by: Ralf Haferkamp <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
dragonchaser
force-pushed
the
ocis-5455-language-setting
branch
2 times, most recently
from
d3d4ba2
to
6ec9891
Compare
Co-authored-by: Julian Koberg <[email protected]> Co-authored-by: Ralf Haferkamp <[email protected]> Co-authored-by: Michael Barz <[email protected]> Signed-off-by: Christian Richter <[email protected]>
dragonchaser
force-pushed
the
ocis-5455-language-setting
branch
from
6ec9891
to
15699f0
Compare
Co-authored-by: Florian Schade <[email protected]> Signed-off-by: Christian Richter <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
fschade
approved these changes
Nov 15, 2023
| return "", "", err | ||
| } | ||
|
|
||
| langVal := gvr.GetValue().GetValue().GetListValue().GetValues() |
There was a problem hiding this comment.
looks fishy.... but seems to be ok
There was a problem hiding this comment.
Results from generated Code 🤷
ownclouders
pushed a commit
that referenced
this pull request
Nov 15, 2023
Ocis 5455 language setting
ownclouders
pushed a commit
that referenced
this pull request
Nov 15, 2023
Ocis 5455 language setting
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Add preferred language to user settings
We have added the preferred language to the libre-graph api & added endpoints for that to ocis.
refs #5455
refs owncloud/libre-graph-api#130