add user filter startsWith and contains #7739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonchaser
force-pushed
the
ocis-5486-filter-displayName
branch
2 times, most recently
from
40707a8
to
576dec1
Compare
rhafer
reviewed
Nov 17, 2023
There was a problem hiding this comment.
I am fine with merging this as is. Though in the long run would be good to have some better filtering support in the backend (as noted, for the contains function that should already work with GetUsers(), feel free to try that out).
Doing all the filtering inside the server will get us into problems at some point.
Signed-off-by: Christian Richter <[email protected]>
dragonchaser
force-pushed
the
ocis-5486-filter-displayName
branch
2 times, most recently
from
fb6403d
to
06a66e8
Compare
rhafer
approved these changes
Nov 22, 2023
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Nov 22, 2023
add user filter startsWith and contains
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Add user filter startswith and contains
We add two new filters to the user list endpoint. The
startswithfilter allows tofilter users by the beginning of their name. The
containsfilter allows tofilter users by a substring of their name.
refs #5486