Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix last month search #7742

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix last month search #7742

merged 1 commit into from
Nov 17, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Nov 16, 2023

Description

Fix the last month edge case when currently is 31-th golang/go#31145

Related Issue

Motivation and Context

How Has This Been Tested?

  • unit tests added

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small thing.. 🚀

@@ -0,0 +1,6 @@
Bugfix: Fix last month search

Fix the last month edge case when currently is 31-th https://github.com/golang/go/issues/31145
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... for the last day in months with 31 days

also please move the issue to the footnote to support calens changelog gen

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@2403905 2403905 merged commit ba7678a into owncloud:master Nov 17, 2023
2 checks passed
ownclouders pushed a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REPORT request at dates >30 with Mtime: "last month" pattern returns current month files
2 participants