Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] bump reva #7746

Merged
merged 2 commits into from
Nov 17, 2023
Merged

[full-ci] bump reva #7746

merged 2 commits into from
Nov 17, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Nov 17, 2023

Description

We fixed the Disabled DEPTH infinity in PROPFIND for:
Personal /remote.php/dav/files/admin
Public link share /remote.php/dav/public-files/
Trashbin /remote.php/dav/spaces/trash-bin/

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Nov 17, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@2403905 2403905 changed the title fix disable depth infinity [full-ci] bump reva fix disable depth infinity Nov 17, 2023
fix disable depth infinity
@2403905 2403905 changed the title [full-ci] bump reva fix disable depth infinity [full-ci] bump reva Nov 17, 2023
@saw-jan
Copy link
Member

saw-jan commented Nov 17, 2023

this might make the test pass

Scenario: get the list of resources in a folder shared through public link with depth infinity
    Given using new DAV path 
-   And the config "OCIS_SHARING_PUBLIC_SHARE_MUST_HAVE_PASSWORD" has been set to "false"
+   And the following configs have been set:
+     | config                                       | value |
+     | OCDAV_ALLOW_PROPFIND_DEPTH_INFINITY          | true  |
+     | OCIS_SHARING_PUBLIC_SHARE_MUST_HAVE_PASSWORD | false |
    And user "Alice" has created a public link share of folder "simple-folder"
    When the public lists the resources in the last created public link with depth "infinity" using the WebDAV API
    Then the HTTP status code should be "207"
    And the last public link DAV response should contain these nodes

Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@2403905
Copy link
Contributor Author

2403905 commented Nov 17, 2023

this might make the test pass

Scenario: get the list of resources in a folder shared through public link with depth infinity
    Given using new DAV path 
-   And the config "OCIS_SHARING_PUBLIC_SHARE_MUST_HAVE_PASSWORD" has been set to "false"
+   And the following configs have been set:
+     | config                                       | value |
+     | OCDAV_ALLOW_PROPFIND_DEPTH_INFINITY          | true  |
+     | OCIS_SHARING_PUBLIC_SHARE_MUST_HAVE_PASSWORD | false |
    And user "Alice" has created a public link share of folder "simple-folder"
    When the public lists the resources in the last created public link with depth "infinity" using the WebDAV API
    Then the HTTP status code should be "207"
    And the last public link DAV response should contain these nodes

Thank you. It helped.

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😍

@micbar micbar merged commit 74a51d5 into owncloud:master Nov 17, 2023
2 checks passed
ownclouders pushed a commit that referenced this pull request Nov 17, 2023
ownclouders pushed a commit that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable DEPTH:infinity in PROPFIND is only applicable to dav/spaces path
3 participants