Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Update reva to move validation to the public share provider #7877

Merged
merged 7 commits into from
Dec 6, 2023
Merged

[full-ci] Update reva to move validation to the public share provider #7877

merged 7 commits into from
Dec 6, 2023

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Dec 4, 2023 •
edited
Loading

Description

This is the ocis part of cs3org/reva#4372

It makes the password policy config global.

-        "FRONTEND_PASSWORD_POLICY_MIN_CHARACTERS": 1,
-        "FRONTEND_PASSWORD_POLICY_MIN_LOWERCASE_CHARACTERS": 0,
-        "FRONTEND_PASSWORD_POLICY_MIN_UPPERCASE_CHARACTERS": 0,
-        "FRONTEND_PASSWORD_POLICY_MIN_DIGITS": 0,
-        "FRONTEND_PASSWORD_POLICY_MIN_SPECIAL_CHARACTERS": 0,
+        "OCIS_PASSWORD_POLICY_MIN_CHARACTERS": 1,
+        "OCIS_PASSWORD_POLICY_MIN_LOWERCASE_CHARACTERS": 0,
+        "OCIS_PASSWORD_POLICY_MIN_UPPERCASE_CHARACTERS": 0,
+        "OCIS_PASSWORD_POLICY_MIN_DIGITS": 0,
+        "OCIS_PASSWORD_POLICY_MIN_SPECIAL_CHARACTERS": 0,

Already existing

OCIS_SHARING_PUBLIC_SHARE_MUST_HAVE_PASSWORD and OCIS_SHARING_PUBLIC_WRITEABLE_SHARE_MUST_HAVE_PASSWORD

have already been there

Frontend service

        "FRONTEND_SHARING_PUBLIC_WRITEABLE_SHARE_MUST_HAVE_PASSWORD"
        "FRONTEND_PUBLIC_SHARE_MUST_HAVE_PASSWORD"
        "FRONTEND_PASSWORD_POLICY_MIN_CHARACTERS"
        "FRONTEND_PASSWORD_POLICY_MIN_LOWERCASE_CHARACTERS"
        "FRONTEND_PASSWORD_POLICY_MIN_UPPERCASE_CHARACTERS"
        "FRONTEND_PASSWORD_POLICY_MIN_DIGITS"
        "FRONTEND_PASSWORD_POLICY_MIN_SPECIAL_CHARACTERS"

Sharing service

        "SHARING_PUBLIC_WRITEABLE_SHARE_MUST_HAVE_PASSWORD" (new!)
        "SHARING_PUBLIC_SHARE_MUST_HAVE_PASSWORD"
        "SHARING_PASSWORD_POLICY_MIN_CHARACTERS"
        "SHARING_PASSWORD_POLICY_MIN_LOWERCASE_CHARACTERS"
        "SHARING_PASSWORD_POLICY_MIN_UPPERCASE_CHARACTERS"
        "SHARING_PASSWORD_POLICY_MIN_DIGITS"
        "SHARING_PASSWORD_POLICY_MIN_SPECIAL_CHARACTERS"

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Dec 4, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar force-pushed the public-provider-pw branch 10 times, most recently from 17e3582 to 4fd7363 Compare December 6, 2023 08:30
@micbar micbar changed the title move business logic to the provider [full-ci] move business logic to the provider Dec 6, 2023
@ScharfViktor
Copy link
Contributor

ScharfViktor commented Dec 6, 2023 •
edited
Loading

CI is failed
Is a password now required for permission 0 (invite people)?

@micbar
Copy link
Contributor Author

micbar commented Dec 6, 2023

CI is failed Is a password now required for permission 0 (invite people)?

Fixed it. Let us see now.

@micbar micbar marked this pull request as ready for review December 6, 2023 11:23
@micbar micbar requested review from ScharfViktor, rhafer, 2403905 and fschade and removed request for wkloucek, ScharfViktor and rhafer December 6, 2023 11:23
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

28.3% 28.3% Coverage
0.0% 0.0% Duplication

ScharfViktor
ScharfViktor approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the testing side

@micbar micbar mentioned this pull request Dec 6, 2023
Open
22 tasks
@micbar micbar changed the title [full-ci] move business logic to the provider [full-ci] Update reva to move validation to the public share provider Dec 6, 2023
@micbar micbar merged commit 176ac99 into master Dec 6, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the public-provider-pw branch December 6, 2023 13:22
ownclouders pushed a commit that referenced this pull request Dec 6, 2023
@micbar
Merge pull request #7877 from owncloud/public-provider-pw
a2ecb3e 
[full-ci] Update reva to move validation to the public share provider
This was referenced Dec 6, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@2403905 2403905 Awaiting requested review from 2403905

@rhafer rhafer Awaiting requested review from rhafer

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@micbar @ScharfViktor @butonic