feat: Normal user list #7887
Merged
feat: Normal user list #7887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
requested changes
Dec 5, 2023
changelog/unreleased/enhancement-allow-listing-regular-users.md
Outdated
Show resolved
Hide resolved
AlexAndBear
requested changes
Dec 5, 2023
|
I took over here as @jvillafanez can't currently work it. |
@janackermann done. Please re-review |
micbar
approved these changes
Dec 6, 2023
|
Some getUser tests are failing. |
Should be fixed now. I took the chance to also add the group search here now as well. |
rhafer
force-pushed
the
normal_user_list
branch
from
0c6cc02
to
d539361
Compare
Previously we only did a prefix match.
Neither 'BadRequest' (as expected in the unit test) nor 'Unauthorized' (as expected in the API tests) seem correct here. We're no returning 'Forbidden' when an unprivileged users issues a GetUsers request that it is not allowed to perform.
rhafer
force-pushed
the
normal_user_list
branch
from
d539361
to
5193c4b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
micbar
approved these changes
Dec 7, 2023
12 tasks
we can bug where we can get full info about user #5125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow regular users to list other users.
People with account management permissions (such as admins) can list users as they have been until now. This PR won't affect them in any way.
Regular users (without account management permission) can list users with the following restrictions:
Related Issue
#7782
Motivation and Context
How Has This Been Tested?
Manually tested.
Unit tests have been adjusted because some of them where failing due to the user not having enough permissions
Screenshots (if appropriate):
Types of changes
Checklist: